Skip to content

Add MachineCIDR definition to install-config.yaml#722

Merged
russellb merged 2 commits intoopenshift-metal3:masterfrom
bcrochet:machine-cidr
Aug 9, 2019
Merged

Add MachineCIDR definition to install-config.yaml#722
russellb merged 2 commits intoopenshift-metal3:masterfrom
bcrochet:machine-cidr

Conversation

@bcrochet
Copy link
Copy Markdown
Contributor

@bcrochet bcrochet commented Aug 5, 2019

openshift/installer#2140 adds validation that the VIPs are a) in the
MachineCIDR and b) not in ClusterNetworks or ServiceNetworks.

This patch defines the MachineCIDR to EXTERNAL_SUBNET in order to
satisfy the first requirement.

openshift/installer#2140 adds validation that the VIPs are a) in the
MachineCIDR and b) not in ClusterNetworks or ServiceNetworks.

This patch defines the MachineCIDR to EXTERNAL_SUBNET in order to
satisfy the first requirement.
@cybertron
Copy link
Copy Markdown
Contributor

We'll also need to add this to the example install-config in https://github.com/openshift/installer/blob/master/docs/user/metal/install_ipi.md

@bcrochet
Copy link
Copy Markdown
Contributor Author

bcrochet commented Aug 5, 2019

We'll also need to add this to the example install-config in https://github.com/openshift/installer/blob/master/docs/user/metal/install_ipi.md

Thanks for the suggestion. I'll add it to my installer PR.

@bcrochet
Copy link
Copy Markdown
Contributor Author

bcrochet commented Aug 5, 2019

/cc @celebdor

@russellb russellb merged commit 2e0299f into openshift-metal3:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants