baremetal: Validate VIPs are in MachineCIDR#2140
baremetal: Validate VIPs are in MachineCIDR#2140openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/L
|
/retest |
openshift/installer#2140 adds validation that the VIPs are a) in the MachineCIDR and b) not in ClusterNetworks or ServiceNetworks. This patch defines the MachineCIDR to EXTERNAL_SUBNET in order to satisfy the first requirement.
|
/test e2e-aws |
The API, DNS, and Ingress virtual IPs (VIPs) should be contained within the MachineCIDR, but not ClusterNetworks, or ServiceNetworks. This adds those validations for the baremetal platform. Closes: openshift#2006
bcrochet
changed the title
|
Updated the commit message, and the title of the PR. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, bcrochet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/label platform/baremetal |
|
/test e2e-aws-scaleup-rhel7 |
|
@bcrochet: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1017/ |
7 participants
The API, DNS, and Ingress virtual IPs (VIPs) should be contained within
the MachineCIDR, but not ClusterNetworks, or ServiceNetworks. This adds those
validations for the baremetal platform.
Closes: #2006