Skip to content

moving mco api/crd to openshift/api#1060

Closed
kikisdeliveryservice wants to merge 5 commits into
openshift:masterfrom
kikisdeliveryservice:mco-api-move2
Closed

moving mco api/crd to openshift/api#1060
kikisdeliveryservice wants to merge 5 commits into
openshift:masterfrom
kikisdeliveryservice:mco-api-move2

Conversation

@kikisdeliveryservice
Copy link
Copy Markdown

@kikisdeliveryservice kikisdeliveryservice commented Nov 18, 2021

Successfully ran make generate-with-container on these changes.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2021
@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Nov 18, 2021
Closed
@openshift-ci openshift-ci Bot requested review from bparees and sjenning November 18, 2021 00:55
@kikisdeliveryservice
Copy link
Copy Markdown
Author

kikisdeliveryservice commented Nov 18, 2021

Hmmm seem to be hitting errors in the generated files. Will keep digging/working on this.

kikisdeliveryservice
kikisdeliveryservice commented Nov 18, 2021
View reviewed changes
Comment thread machineconfiguration/v1/helpers.go Outdated
kikisdeliveryservice
kikisdeliveryservice commented Nov 18, 2021
View reviewed changes
Comment thread machineconfiguration/v1/helpers_test.go Outdated
kikisdeliveryservice
kikisdeliveryservice commented Nov 18, 2021
View reviewed changes
Comment thread machineconfiguration/v1/generated.pb.go Outdated
@kikisdeliveryservice kikisdeliveryservice force-pushed the mco-api-move2 branch 2 times, most recently from 38419fd to a4b40eb Compare November 20, 2021 01:59
kikisdeliveryservice
kikisdeliveryservice commented Nov 20, 2021
View reviewed changes
Comment thread machineconfiguration/v1/types.go
@kikisdeliveryservice kikisdeliveryservice force-pushed the mco-api-move2 branch 3 times, most recently from a4b40eb to ba758e2 Compare November 23, 2021 23:25
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kikisdeliveryservice
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kikisdeliveryservice
To complete the pull request process, please assign sttts after the PR has been reviewed.
You can assign the PR to them by writing /assign @sttts in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice kikisdeliveryservice force-pushed the mco-api-move2 branch 2 times, most recently from d2d6099 to b33d5b1 Compare November 24, 2021 00:40
@kikisdeliveryservice kikisdeliveryservice changed the title [WIP] moving mco api/crd to openshift/api moving mco api/crd to openshift/api Nov 24, 2021
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2021
@kikisdeliveryservice
Copy link
Copy Markdown
Author

kikisdeliveryservice commented Nov 24, 2021 •
edited
Loading

Re-added generated.pb.go and generated.proto and now all of the tests are failing bc of undeclared types that are created in the generated files but should be covered by the imports in those files?

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_api/1060/pull-ci-openshift-api-master-verify/1463580558331219968

Something is wrong here, but not really sure what.

Also not sure if these files are needed/required other than for these tests since I've seen other PRs/dirs merge without them.

@kikisdeliveryservice
Copy link
Copy Markdown
Author

kikisdeliveryservice commented Dec 2, 2021

Following-up: any reviews?

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Mar 2, 2022

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 2, 2022

@kikisdeliveryservice: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 1, 2022

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 1, 2022
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented May 2, 2022

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci Bot closed this May 2, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 2, 2022

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sinnykumari sinnykumari mentioned this pull request Jul 8, 2022
Closed
@jkyros jkyros mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kikisdeliveryservice @openshift-bot @sttts