[Do not merge] Extending the ClusterStatusConditionType for clusterversion type#1117
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LalatenduMohanty The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| // a control plane host is unhealthy and must be replaced. A component should | ||
| // report Degraded if unexpected errors occur over a period, but the | ||
| // expectation is that all unexpected errors are handled as operators mature. | ||
| OperatorDegraded ClusterVersionStatusConditionType = "Degraded" |
There was a problem hiding this comment.
ClusterVersion doesn't do Degraded (we use Failing with the same semantics), so you can probably drop this and/or recycle its docs for the Failing constant.
LalatenduMohanty
force-pushed
the
clusterversion_failing_status_condition
branch
from
2b5026a to
b410392
Compare
Cluster version operator already using the "Failing" ClusterStatusConditionType. Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
LalatenduMohanty
force-pushed
the
clusterversion_failing_status_condition
branch
from
b410392 to
3ed8943
Compare
|
@LalatenduMohanty: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
Cluster version operator already using the "Failing"
ClusterStatusConditionType. So adding it back.
It was removed from operator types in #288 . It is not clear why this was removed but it was added in CVO code in openshift/cluster-version-operator@7f5b7f4
Signed-off-by: Lalatendu Mohanty lmohanty@redhat.com