Skip to content

Remove OperatorStatusTypeFailing entirely#288

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
eparis:more-failing-rename
Apr 18, 2019
Merged

Remove OperatorStatusTypeFailing entirely#288
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
eparis:more-failing-rename

Conversation

@eparis
Copy link
Copy Markdown
Member

@eparis eparis commented Apr 17, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@eparis eparis changed the title remove failing entirely Remove OperatorStatusTypeFailing entirely Apr 17, 2019
@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

see: #287

@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

/retest

@eparis eparis force-pushed the more-failing-rename branch from 5b7ffda to 60584d1 Compare April 17, 2019 23:51
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 18, 2019

/lgtm
/hold

unhold at a time you find appropriate

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 18, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, eparis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 18, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 18b9f98 into openshift:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants