Skip to content

Remove CloudControllerManagerSpec from the External platform spec#1409

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
lobziik:extrernal-resource-remove-ccm
Feb 17, 2023
Merged

Remove CloudControllerManagerSpec from the External platform spec#1409
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
lobziik:extrernal-resource-remove-ccm

Conversation

@lobziik
Copy link
Copy Markdown
Contributor

@lobziik lobziik commented Feb 17, 2023

Due to priority changes for the Installer Flexibility effort,
the decision about temporarily removing CloudControllerManagerSpec from the Infrastructure resource was made.

cc @elmiko @JoelSpeed

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2023

Hello @lobziik! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot requested review from eparis and knobunc February 17, 2023 14:05
@lobziik
Copy link
Copy Markdown
Contributor Author

lobziik commented Feb 17, 2023

/cc @elmiko
/cc @JoelSpeed

@openshift-ci openshift-ci Bot requested review from JoelSpeed and elmiko February 17, 2023 14:09
Due to priority changes for the Installer Flexibility effort,
we decided to temporarily remove CloudControllerManagerSpec
from the Infrastructure spec.
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2023

@lobziik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lobziik
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@JoelSpeed
Copy link
Copy Markdown
Contributor

I spoke to Denis before about this, this API was merged during the 4.13 cycle, but we aren't going to get to implementing it within 4.13. Best to remove the API and reintroduce it in a later release when we are ready to implement the backing logic
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, JoelSpeed, lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit ab002e9 into openshift:master Feb 17, 2023
adriengentil added a commit to adriengentil/api that referenced this pull request Apr 5, 2023
…platform spec

Revert PR openshift#1409 in order to support
external platform type.

* Enhancement doc update PR (<placeholder>)

This reverts commit e8d6cd0.
adriengentil added a commit to adriengentil/api that referenced this pull request May 3, 2023
…tform status

Partially revert PR openshift#1409 in order to support
external platform type.

* Enhancement doc update PR (<placeholder>)
adriengentil added a commit to adriengentil/api that referenced this pull request May 3, 2023
…tform status

Partially revert PR openshift#1409 in order to support
external platform type.

* Enhancement doc update PR (<placeholder>)
adriengentil added a commit to adriengentil/api that referenced this pull request May 17, 2023
…tform status

Partially revert PR openshift#1409 in order to support
external platform type.

* Enhancement doc update PR (<placeholder>)
adriengentil added a commit to adriengentil/api that referenced this pull request Jun 2, 2023
…tform status

Partially revert PR openshift#1409 in order to support
external platform type.

* Enhancement doc update PR (<placeholder>)
adriengentil added a commit to adriengentil/api that referenced this pull request Jun 12, 2023
…tform status

Partially revert PR openshift#1409 in order to support
external platform type.

* Enhancement doc update PR (<placeholder>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants