Skip to content

Update External platform type EP with implementation histotry block#1353

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
lobziik:platform-external-upd
Feb 17, 2023
Merged

Update External platform type EP with implementation histotry block#1353
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
lobziik:platform-external-upd

Conversation

@lobziik
Copy link
Copy Markdown
Contributor

@lobziik lobziik commented Feb 17, 2023

This PR proposes updates that contain links to the merged and upcoming changes for openshift/api in regards to the External platform implementation.

@lobziik
Copy link
Copy Markdown
Contributor Author

lobziik commented Feb 17, 2023

/cc @elmiko

Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice to update here as well, thanks!
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2023
@dhellmann
Copy link
Copy Markdown
Contributor

This is OK, but generally we'd rather have a tracking link at the top of the doc that people can go to look at for all of the implementation work. That avoids having to come back here and add follow-up patches like this and keeps the ticket system as the source of information for work-in-progress.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2023
@elmiko
Copy link
Copy Markdown
Contributor

elmiko commented Feb 17, 2023

this is probably an oversight on my part, i don't think we ever created a jira card to capture backing out these changes. it's no excuse, but a lesson for next time to improve our process.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 17, 2023

@lobziik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5741c17 into openshift:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants