Skip to content

Add Evented Pleg as a Tech Preview feature in the Openshift#1471

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sairameshv:evented-pleg-tp
May 25, 2023
Merged

Add Evented Pleg as a Tech Preview feature in the Openshift#1471
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
sairameshv:evented-pleg-tp

Conversation

@sairameshv
Copy link
Copy Markdown
Member

@sairameshv sairameshv commented May 25, 2023

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2023

Hello @sairameshv! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 25, 2023
@sairameshv
Copy link
Copy Markdown
Member Author

sairameshv commented May 25, 2023

/cc @mrunalp @deads2k

@sairameshv sairameshv mentioned this pull request May 25, 2023
Closed
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented May 25, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sairameshv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2023

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented May 25, 2023 •
edited
Loading

/hold to get #1473 first

trying to get serialization fixes. Will unhold after merge.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 70c06e9 into openshift:master May 25, 2023
@sairameshv sairameshv mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mrunalp mrunalp Awaiting requested review from mrunalp

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sairameshv @deads2k @openshift-merge-robot