OCPBUGS-3176: Rework IP Forwarding config

[trozet]

We are not supposed to use booleans anymore for API, so modifying the config to use a new type.

https://github.com/openshift/crd-schema-checker/blob/master/pkg/manifestcomparators/comp_no_bools.go#L20

[openshift-ci-robot]

@trozet: This pull request references Jira Issue OCPBUGS-3176, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

We are not supposed to use booleans anymore for API, so modifying the config to use a new type.

https://github.com/openshift/crd-schema-checker/blob/master/pkg/manifestcomparators/comp_no_bools.go#L20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hello @trozet! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[trozet]

/assign @deads2k

/assign @tssurya

[deads2k]

/lgtm

tagging so we get the types right for deserialization before we update cluster-config-operator to write the CRs. I'll make a followup to tweak validation.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@trozet: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@trozet: Jira Issue OCPBUGS-3176: Some pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#1626
• openshift/machine-config-operator#3676
• openshift/api#1468

The following pull requests linked via external trackers have not merged:

• openshift/sdn#549 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-3176 has not been moved to the MODIFIED state.

Details

In response to this:

We are not supposed to use booleans anymore for API, so modifying the config to use a new type.

https://github.com/openshift/crd-schema-checker/blob/master/pkg/manifestcomparators/comp_no_bools.go#L20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929