Skip to content

OCPBUGS-3176: Enable IP Forwarding if disabled#549

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
trozet:OCPBUGS-3176
May 26, 2023
Merged

OCPBUGS-3176: Enable IP Forwarding if disabled#549
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
trozet:OCPBUGS-3176

Conversation

@trozet
Copy link
Copy Markdown
Contributor

@trozet trozet commented May 25, 2023

With changes to disable IP forwarding by default with OVNK: openshift/machine-config-operator#3676

OVN to SDN migration is now broken, because pods roll out first that require IP forwarding. IP forwarding for SDN is enabled via MCO node rollout, which happens later.

This change enables IP forwarding in the SDN pod itself if needed.

With changes to disable IP forwarding by default with OVNK:
openshift/machine-config-operator#3676

OVN to SDN migration is now broken, because pods roll out first that
require IP forwarding. IP forwarding for SDN is enabled via MCO node
rollout, which happens later.

This change enables IP forwarding in the SDN pod itself if needed.

Signed-off-by: Tim Rozet <trozet@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 25, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@trozet: This pull request references Jira Issue OCPBUGS-3176, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

With changes to disable IP forwarding by default with OVNK: openshift/machine-config-operator#3676

OVN to SDN migration is now broken, because pods roll out first that require IP forwarding. IP forwarding for SDN is enabled via MCO node rollout, which happens later.

This change enables IP forwarding in the SDN pod itself if needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2023
@trozet
Copy link
Copy Markdown
Contributor Author

trozet commented May 25, 2023

/assign @kyrtapz

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented May 25, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 763eafe and 2 for PR HEAD 5c198d3 in total

@pliurh
Copy link
Copy Markdown
Contributor

pliurh commented May 26, 2023

I tested this PR. It works in SDN migration.

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented May 26, 2023

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 26, 2023

@trozet: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5723908 into openshift:master May 26, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@trozet: Jira Issue OCPBUGS-3176: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-3176 has been moved to the MODIFIED state.

Details

In response to this:

With changes to disable IP forwarding by default with OVNK: openshift/machine-config-operator#3676

OVN to SDN migration is now broken, because pods roll out first that require IP forwarding. IP forwarding for SDN is enabled via MCO node rollout, which happens later.

This change enables IP forwarding in the SDN pod itself if needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-11-201102

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-12-024050

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-09-15-101929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants