[release-4.12] OCPBUGS-15251: Add protocolStrategy for upstreams in dnses.operator.openshift.io by openshift-cherrypick-robot · Pull Request #1502 · openshift/api

openshift-cherrypick-robot · 2023-06-21T13:19:18Z

This is an automated cherry-pick of #1429

/assign gcs278

…enshift.io protocolStrategy adds the ability to configure the force_tcp CoreDNS Corefile configuration for upstreams, which forces TCP for all upstream DNS requests. This is to resolve issues regarding problematic DNS upstreams as well as a potential UDP reliability problems.

openshift-ci-robot · 2023-06-21T13:19:29Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-6829 has been cloned as Jira Issue OCPBUGS-15251. Will retitle bug to link to clone.
/retitle [release-4.12] OCPBUGS-15251: Add protocolStrategy for upstreams in dnses.operator.openshift.io

Details

In response to this:

This is an automated cherry-pick of #1429

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-06-21T13:19:54Z

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot · 2023-06-21T13:20:16Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15251, which is invalid:

expected dependent Jira Issue OCPBUGS-6829 to target a version in 4.13.0, 4.13.z, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1429

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-06-21T13:21:54Z

/jira refresh

openshift-ci-robot · 2023-06-21T13:21:57Z

@gcs278: This pull request references Jira Issue OCPBUGS-15251, which is invalid:

expected dependent Jira Issue OCPBUGS-15225 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead
expected dependent Jira Issue OCPBUGS-6829 to target a version in 4.13.0, 4.13.z, but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-06-21T13:22:32Z

/jira refresh

openshift-ci-robot · 2023-06-21T13:22:35Z

@gcs278: This pull request references Jira Issue OCPBUGS-15251, which is invalid:

expected dependent Jira Issue OCPBUGS-15225 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-06-21T15:20:04Z

Slack Discussion about backporting

candita · 2023-06-21T21:05:10Z

/assign
cc @Miciah if you're already involved

candita · 2023-06-21T21:06:02Z

@gcs278 can you investigate the verify-client-go failure?

gcs278 · 2023-06-21T21:42:09Z

@candita will look into it.
Let me try one more time
/test verify-client-go

candita · 2023-06-22T18:30:15Z

Backport looks correct, and justification for backport from Slack thread has been approved by team lead, PM, and manager.
/lgtm

candita · 2023-06-22T18:31:25Z

@gcs278 you'll need to check in to the verify-client-go failure. It may be that this can't be backported to 4.12 after all.

mv ./vendor/k8s.io/code-generator/generate-groups.sh.orig ./vendor/k8s.io/code-generator/generate-groups.sh
insights/applyconfigurations/insights/v1alpha1/datagather.go:6:2: cannot find package "github.com/openshift/client-go/vendor/github.com/openshift/api/insights/v1alpha1" in:
/go/src/github.com/openshift/client-go/vendor/github.com/openshift/api/insights/v1alpha1
monitoring/applyconfigurations/monitoring/v1/alertingrule.go:6:2: cannot find package "github.com/openshift/client-go/vendor/github.com/openshift/api/monitoring/v1" in:
/go/src/github.com/openshift/client-go/vendor/github.com/openshift/api/monitoring/v1

gcs278 · 2023-06-23T17:23:14Z

I spent sometime investigating, but it doesn't look like it's a failure that is specific to this PR, but more of a repo-level code generation issue. I asked forum-api-review here: https://redhat-internal.slack.com/archives/CE4L0F143/p1687540934599509

candita · 2023-07-13T23:56:54Z

@gcs278 can you follow up on the slack thread regarding verify-client-go?

melvinjoseph86 · 2023-07-17T04:23:27Z

/jira refresh

openshift-ci-robot · 2023-07-17T04:23:33Z

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-15251, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.12.z) matches configured target version for branch (4.12.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-15225 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-15225 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2023-07-21T21:59:16Z

/test verify-client-go

Miciah · 2023-07-24T23:02:56Z

I've filed OCPBUGS-16720 for the verify-client-go failures.

JoelSpeed · 2023-07-26T13:29:32Z

/test verify-client-go

openshift-ci · 2023-07-26T13:39:45Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gcs278 · 2023-07-26T14:51:41Z

@JoelSpeed thanks for following up with the verify-client-go fixes.

Could I get you to apply approve and backport-risk-assessed to this PR?

JoelSpeed · 2023-07-26T15:32:55Z

Do we have staff eng approval for backporting this? Typically backporting features into z streams has strict requirements, especially for going back a couple of releases

gcs278 · 2023-07-26T16:49:27Z

Do we have staff eng approval for backporting this? Typically backporting features into z streams has strict requirements, especially for going back a couple of releases

@JoelSpeed I was slightly mistaken. For the 4.13 backport, @soltysh approved it, looks like he is on vacation though. PM has approved it in this Slack Thread.

soltysh

/approve
/label backport-risk-assessed

openshift-ci · 2023-08-04T15:40:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

melvinjoseph86 · 2023-08-04T16:33:33Z

/label cherry-pick-approved

openshift-ci · 2023-08-04T16:33:49Z

@melvinjoseph86: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

melvinjoseph86 · 2023-08-08T05:49:42Z

@gangwgr @wangke19 @xingxingxia Kindly help adding cherry-pick-approved label

gcs278 · 2023-08-14T16:57:56Z

@gangwgr @wangke19 @xingxingxia Kindly help adding cherry-pick-approved label

Friendly reminder

xingxingxia · 2023-08-16T02:20:42Z

/label cherry-pick-approved

openshift-ci-robot · 2023-08-16T02:25:12Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15251: Some pull requests linked via external trackers have merged:

openshift/api#1502

The following pull requests linked via external trackers have not merged:

openshift/cluster-dns-operator#378 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-15251 has not been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1429

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-09-09T00:48:39Z

Fix included in accepted release 4.12.0-0.nightly-2023-09-08-181253

openshift-cherrypick-robot mentioned this pull request Jun 21, 2023

OCPBUGS-6829: Add protocolStrategy for upstreams in dnses.operator.openshift.io #1429

Merged

openshift-cherrypick-robot assigned gcs278 Jun 21, 2023

openshift-ci Bot changed the title ~~[release-4.12] OCPBUGS-6829: Add protocolStrategy for upstreams in dnses.operator.openshift.io~~ [release-4.12] OCPBUGS-15251: Add protocolStrategy for upstreams in dnses.operator.openshift.io Jun 21, 2023

openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 21, 2023

openshift-ci Bot requested review from knobunc and soltysh June 21, 2023 13:30

openshift-ci Bot assigned candita Jun 21, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jul 17, 2023

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 17, 2023

openshift-ci Bot requested a review from melvinjoseph86 July 17, 2023 04:23

soltysh approved these changes Aug 4, 2023

View reviewed changes

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 4, 2023

openshift-ci Bot assigned gangwgr, wangke19 and xingxingxia Aug 4, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023

gcs278 mentioned this pull request Aug 7, 2023

[release-4.12] OCPBUGS-15251: Add support for protocolStrategy API field to enable force_tcp configuration openshift/cluster-dns-operator#378

Merged

openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 16, 2023

openshift-merge-robot merged commit b8dd6b6 into openshift:release-4.12 Aug 16, 2023

Conversation

openshift-cherrypick-robot commented Jun 21, 2023

Uh oh!

openshift-ci-robot commented Jun 21, 2023

Uh oh!

openshift-ci Bot commented Jun 21, 2023

Uh oh!

openshift-ci-robot commented Jun 21, 2023

Uh oh!

gcs278 commented Jun 21, 2023

Uh oh!

openshift-ci-robot commented Jun 21, 2023

Uh oh!

gcs278 commented Jun 21, 2023

Uh oh!

openshift-ci-robot commented Jun 21, 2023

Uh oh!

gcs278 commented Jun 21, 2023

Uh oh!

candita commented Jun 21, 2023

Uh oh!

candita commented Jun 21, 2023

Uh oh!

gcs278 commented Jun 21, 2023

Uh oh!

candita commented Jun 22, 2023

Uh oh!

candita commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcs278 commented Jun 23, 2023

Uh oh!

candita commented Jul 13, 2023

Uh oh!

melvinjoseph86 commented Jul 17, 2023

Uh oh!

openshift-ci-robot commented Jul 17, 2023

Uh oh!

Miciah commented Jul 21, 2023

Uh oh!

Miciah commented Jul 24, 2023

Uh oh!

JoelSpeed commented Jul 26, 2023

Uh oh!

openshift-ci Bot commented Jul 26, 2023

Uh oh!

gcs278 commented Jul 26, 2023

Uh oh!

JoelSpeed commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gcs278 commented Jul 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 4, 2023

Uh oh!

melvinjoseph86 commented Aug 4, 2023

Uh oh!

openshift-ci Bot commented Aug 4, 2023

Uh oh!

melvinjoseph86 commented Aug 8, 2023

Uh oh!

gcs278 commented Aug 14, 2023

Uh oh!

xingxingxia commented Aug 16, 2023

Uh oh!

openshift-ci-robot commented Aug 16, 2023

Uh oh!

openshift-merge-robot commented Sep 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

candita commented Jun 22, 2023 •

edited

Loading

JoelSpeed commented Jul 26, 2023 •

edited

Loading

gcs278 commented Jul 26, 2023 •

edited

Loading