Skip to content

[release-4.13] OCPBUGS-15225: Add protocolStrategy for upstreams in dnses.operator.openshift.io#1500

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1429-to-release-4.13
Jul 11, 2023
Merged

[release-4.13] OCPBUGS-15225: Add protocolStrategy for upstreams in dnses.operator.openshift.io#1500
openshift-merge-robot merged 1 commit intoopenshift:release-4.13from
openshift-cherrypick-robot:cherry-pick-1429-to-release-4.13

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jun 20, 2023

This is an automated cherry-pick of #1429

/assign gcs278

@gcs278
OCPBUGS-6829: Add protocolStrategy for upstreams in dnses.operator.op…
894c546 
…enshift.io

protocolStrategy adds the ability to configure the force_tcp CoreDNS
Corefile configuration for upstreams, which forces TCP for all upstream
DNS requests. This is to resolve issues regarding problematic DNS
upstreams as well as a potential UDP reliability problems.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 20, 2023
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 20, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-6829 has been cloned as Jira Issue OCPBUGS-15225. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-15225: Add protocolStrategy for upstreams in dnses.operator.openshift.io

Details

In response to this:

This is an automated cherry-pick of #1429

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 20, 2023

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot changed the title [release-4.13] OCPBUGS-6829: Add protocolStrategy for upstreams in dnses.operator.openshift.io [release-4.13] OCPBUGS-15225: Add protocolStrategy for upstreams in dnses.operator.openshift.io Jun 20, 2023
@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 20, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 20, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 20, 2023

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-15225, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-6829 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-6829 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1429

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from bparees, lihongan and mfojtik June 20, 2023 21:21
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 20, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Jun 21, 2023

Slack Discussion about backporting

@candita
Copy link
Copy Markdown
Contributor

candita commented Jun 21, 2023

/assign
cc @Miciah if you're involved with this already

@candita
Copy link
Copy Markdown
Contributor

candita commented Jun 22, 2023

Backport looks correct, and justification for backport from Slack thread has been approved by team lead, PM, and manager.
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Jun 27, 2023

@JoelSpeed or @ingvagabund Could I get a review and approve since you all reviewed #1429? It's a pretty straightforward backport.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Jun 30, 2023

/approve
/label backport-risk-assessed

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2023

@JoelSpeed: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-staff-engineers]

Details

In response to this:

/approve
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@melvinjoseph86
Copy link
Copy Markdown

melvinjoseph86 commented Jul 3, 2023

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 3, 2023

@melvinjoseph86: This pull request references Jira Issue OCPBUGS-15225, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-6829 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-6829 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from melvinjoseph86 July 3, 2023 06:52
@gcs278
Copy link
Copy Markdown
Contributor

gcs278 commented Jul 3, 2023

@soltysh Could I get a backport-risk-assessed of this PR please?

soltysh
soltysh approved these changes Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, JoelSpeed, openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gangwgr
Copy link
Copy Markdown

gangwgr commented Jul 11, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit b5a47f9 into openshift:release-4.13 Jul 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 11, 2023

@openshift-cherrypick-robot: Jira Issue OCPBUGS-15225: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-15225 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1429

/assign gcs278

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jul 11, 2023
Closed
Merged
@gcs278 gcs278 mentioned this pull request Jul 26, 2023
Merged
@gcs278 gcs278 mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lihongan lihongan Awaiting requested review from lihongan

@bparees bparees Awaiting requested review from bparees

@mfojtik mfojtik Awaiting requested review from mfojtik

@melvinjoseph86 melvinjoseph86 Awaiting requested review from melvinjoseph86

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@candita candita

@gcs278 gcs278

@xingxingxia xingxingxia

@wangke19 wangke19

@gangwgr gangwgr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.