Skip to content

[release-4.13] OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration#371

Closed
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:force_tcp-4.13
Closed

[release-4.13] OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration#371
gcs278 wants to merge 1 commit intoopenshift:masterfrom
gcs278:force_tcp-4.13

Conversation

@gcs278
Copy link
Copy Markdown
Contributor

@gcs278 gcs278 commented Jul 11, 2023 •
edited
Loading

This is a manual cherry-pick of #359 because the API (openshift/api#1500) is also being backported and needed to be manually vendored.

go.mod: Vendor API support for protocolStrategy
pkg/operator/controller/controller_dns_configmap.go: Logic to add force_tcp in corefile if protocolStrategy is TCP
pkg/operator/controller/controller_dns_configmap_test.go: Unit tests pkg/operator/controller/testdata/*: New corefiles for unit testing

@gcs278
OCPBUGS-6829: Add support for protocolStrategy API field to enable fo…
1fd9ef8 
…rce_tcp configuration

`go.mod`: Vendor API support for protocolStrategy
`pkg/operator/controller/controller_dns_configmap.go`: Logic to add
force_tcp in corefile if protocolStrategy is TCP
`pkg/operator/controller/controller_dns_configmap_test.go`: Unit tests
`pkg/operator/controller/testdata/*`: New corefiles for unit testing
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 11, 2023

@gcs278: This pull request references Jira Issue OCPBUGS-6829, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #359 because the API is also being backported and needed to be manually vendored.

go.mod: Vendor API support for protocolStrategy
pkg/operator/controller/controller_dns_configmap.go: Logic to add force_tcp in corefile if protocolStrategy is TCP
pkg/operator/controller/controller_dns_configmap_test.go: Unit tests pkg/operator/controller/testdata/*: New corefiles for unit testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Jul 11, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278 gcs278 changed the title OCPBUGS-6829: Add support for protocolStrategy API field to enable force_tcp configuration OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration Jul 11, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 11, 2023

@gcs278: This pull request references Jira Issue OCPBUGS-15225, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #359 because the API is also being backported and needed to be manually vendored.

go.mod: Vendor API support for protocolStrategy
pkg/operator/controller/controller_dns_configmap.go: Logic to add force_tcp in corefile if protocolStrategy is TCP
pkg/operator/controller/controller_dns_configmap_test.go: Unit tests pkg/operator/controller/testdata/*: New corefiles for unit testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 11, 2023

@gcs278: This pull request references Jira Issue OCPBUGS-15225, which is invalid:

  • expected the bug to target the "4.14.0" version, but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

This is a manual cherry-pick of #359 because the API (openshift/api#1500) is also being backported and needed to be manually vendored.

go.mod: Vendor API support for protocolStrategy
pkg/operator/controller/controller_dns_configmap.go: Logic to add force_tcp in corefile if protocolStrategy is TCP
pkg/operator/controller/controller_dns_configmap_test.go: Unit tests pkg/operator/controller/testdata/*: New corefiles for unit testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278 gcs278 changed the title OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration [release-4.13] OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration Jul 11, 2023
@gcs278
Copy link
Copy Markdown
Contributor Author

gcs278 commented Jul 11, 2023

/close
whoops, didn't mean to merge to master, need to merge to 4.13

@openshift-ci openshift-ci Bot requested review from alebedev87 and rfredette July 11, 2023 15:05
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gcs278. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot closed this Jul 11, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

@gcs278: Closed this PR.

Details

In response to this:

/close
whoops, didn't mean to merge to master, need to merge to 4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 11, 2023

@gcs278: This pull request references Jira Issue OCPBUGS-15225. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #359 because the API (openshift/api#1500) is also being backported and needed to be manually vendored.

go.mod: Vendor API support for protocolStrategy
pkg/operator/controller/controller_dns_configmap.go: Logic to add force_tcp in corefile if protocolStrategy is TCP
pkg/operator/controller/controller_dns_configmap_test.go: Unit tests pkg/operator/controller/testdata/*: New corefiles for unit testing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 11, 2023

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 1fd9ef8 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-operator 1fd9ef8 link true /test e2e-aws-ovn-operator
ci/prow/e2e-aws-ovn-serial 1fd9ef8 link true /test e2e-aws-ovn-serial
ci/prow/verify 1fd9ef8 link true /test verify
ci/prow/e2e-aws-ovn-upgrade 1fd9ef8 link true /test e2e-aws-ovn-upgrade
ci/prow/images 1fd9ef8 link true /test images
ci/prow/unit 1fd9ef8 link true /test unit
ci/prow/e2e-aws-ovn 1fd9ef8 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gcs278 gcs278 mentioned this pull request Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alebedev87 alebedev87 Awaiting requested review from alebedev87

@rfredette rfredette Awaiting requested review from rfredette

Assignees

No one assigned

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gcs278 @openshift-ci-robot @openshift-merge-robot