OCPBUGS-6829: Add support for protocolStrategy API field to enable force_tcp configuration by gcs278 · Pull Request #359 · openshift/cluster-dns-operator

gcs278 · 2023-03-23T21:06:25Z

Support for protocolStrategy API field to CoreDNS Corefile that allows force_tcp to be enabled on any upstream server configuration.

API: openshift/api#1429

Adds support for the following fields:

spec.upstreamResolvers.protocolStrategy
- For default (".") usptream server
spec.servers[].forwardPlugin.protocolStrategy
- For custom list of DNS resolvers

openshift-ci-robot · 2023-03-23T21:06:31Z

@gcs278: This pull request references Jira Issue OCPBUGS-6829, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

WIP for adding force_tcp API field to CoreDNS Corefile

API: openshift/api#1429

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-03-24T17:13:49Z

/jira refresh

openshift-ci-robot · 2023-03-24T17:13:58Z

@gcs278: This pull request references Jira Issue OCPBUGS-6829, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-24T19:04:48Z

@gcs278: This pull request references Jira Issue OCPBUGS-6829, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

WIP for adding force_tcp API field to CoreDNS Corefile

API: openshift/api#1429

Adds support for the following fields:

spec.upstreamResolvers.protocolPolicy

For default (".") usptream server

spec.servers[].forwardPlugin.protocolPolicy

For custom list of DNS resolvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-03-24T19:05:41Z

@gcs278: This pull request references Jira Issue OCPBUGS-6829, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Support for protocolPolicy API field to CoreDNS Corefile that allows force_tcp to be enabled on any upstream server configuration.

API: openshift/api#1429

Adds support for the following fields:

spec.upstreamResolvers.protocolPolicy

For default (".") usptream server

spec.servers[].forwardPlugin.protocolPolicy

For custom list of DNS resolvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-03-28T19:00:25Z

/hold
requires API bump openshift/api#1429

candita · 2023-03-29T15:46:48Z

/assign @alebedev87
/assign @Miciah

alebedev87

LGTM, will wait for the API bump to revisit. Just a small question.

alebedev87 · 2023-04-05T15:58:58Z

+							ForwardPlugin: operatorv1.ForwardPlugin{
+								Upstreams:      []string{"1.1.1.1", "2.2.2.2:5353"},
+								Policy:         operatorv1.RoundRobinForwardingPolicy,
+								ProtocolPolicy: operatorv1.ProtocolPolicyNone,


I'm wondering whether None wouldn't be the default value in which case it would be tested by the existing forwardplugin and upstreamresolvers test cases.

Update: I think that makes some sense. Sort of double check on the defaulting or omitempty option. This way we have all the three possibilities covered: nothing is specified by the user, none and forcetcp. Don't mind my previous comment.

With recent updates to this API, which have just merged, we now have "" and TCP. omitempty was removed due to new API conventions (or previously un-followed conventions).
https://github.com/openshift/api/blob/333bc194ef7a13338a4343c25f81ff856ab0d0fd/operator/v1/types_dns.go#L425

melvinjoseph86 · 2023-05-11T05:59:29Z

/test e2e-aws-ovn-upgrade

melvinjoseph86 · 2023-05-11T07:56:06Z

Pre verify the changes with cluster bot and steps are below:
https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-63512
/label qe-approved

openshift-ci-robot · 2023-05-17T14:47:09Z

@gcs278: An error was encountered querying GitHub for users with public email (mjoseph@redhat.com) for bug OCPBUGS-6829 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Support for protocolStrategy API field to CoreDNS Corefile that allows force_tcp to be enabled on any upstream server configuration.

API: openshift/api#1429

Adds support for the following fields:

spec.upstreamResolvers.protocolStrategy

For default (".") usptream server

spec.servers[].forwardPlugin.protocolStrategy

For custom list of DNS resolvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gcs278 · 2023-05-17T16:11:35Z

We need to bump k8s to 0.27, but we are currently broke on #368 (comment).

Using #368 to bump k8s.

melvinjoseph86 · 2023-05-26T08:56:16Z

/retest-required

…rce_tcp configuration `go.mod`: Vendor API support for protocolStrategy `pkg/operator/controller/controller_dns_configmap.go`: Logic to add force_tcp in corefile if protocolStrategy is TCP `pkg/operator/controller/controller_dns_configmap_test.go`: Unit tests `pkg/operator/controller/testdata/*`: New corefiles for unit testing

gcs278 · 2023-05-26T14:51:38Z

/unhold
1.27 rebase has merged. Rebased and ready to go.

openshift-ci · 2023-05-26T17:22:38Z

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Miciah · 2023-05-30T21:42:55Z

/approve
/lgtm
/hold
for @alebedev87.

openshift-ci · 2023-05-30T21:43:21Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alebedev87 · 2023-06-05T17:17:27Z

/unhold

openshift-ci-robot · 2023-06-05T17:21:46Z

@gcs278: Jira Issue OCPBUGS-6829: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6829 has been moved to the MODIFIED state.

Details

In response to this:

Support for protocolStrategy API field to CoreDNS Corefile that allows force_tcp to be enabled on any upstream server configuration.

API: openshift/api#1429

Adds support for the following fields:

spec.upstreamResolvers.protocolStrategy

For default (".") usptream server

spec.servers[].forwardPlugin.protocolStrategy

For custom list of DNS resolvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. label Mar 23, 2023

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 23, 2023

openshift-ci Bot requested review from frobware and knobunc March 23, 2023 21:06

gcs278 force-pushed the force_tcp branch from 188a3f5 to e9fc282 Compare March 24, 2023 18:57

gcs278 changed the title ~~[WIP] OCPBUGS-6829: Add support for force_tcp API field~~ [WIP] OCPBUGS-6829: Add support for protocolPolicy API field to enable force_tcp configuration Mar 24, 2023

gcs278 force-pushed the force_tcp branch from e9fc282 to e135d82 Compare March 24, 2023 18:59

gcs278 changed the title ~~[WIP] OCPBUGS-6829: Add support for protocolPolicy API field to enable force_tcp configuration~~ OCPBUGS-6829: Add support for protocolPolicy API field to enable force_tcp configuration Mar 28, 2023

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023

openshift-ci Bot assigned alebedev87 and Miciah Mar 29, 2023

alebedev87 reviewed Apr 5, 2023

View reviewed changes

gcs278 mentioned this pull request May 3, 2023

OCPBUGS-6829: Add protocolStrategy for upstreams in dnses.operator.openshift.io openshift/api#1429

Merged

gcs278 force-pushed the force_tcp branch 2 times, most recently from dbe5cc4 to 2d80926 Compare May 8, 2023 18:03

gcs278 changed the title ~~OCPBUGS-6829: Add support for protocolPolicy API field to enable force_tcp configuration~~ OCPBUGS-6829: Add support for protocolStrategy API field to enable force_tcp configuration May 8, 2023

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 11, 2023

gcs278 force-pushed the force_tcp branch from 2d80926 to fcbd3e7 Compare May 17, 2023 15:06

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023

gcs278 force-pushed the force_tcp branch from fcbd3e7 to bb271be Compare May 17, 2023 15:28

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2023

gcs278 force-pushed the force_tcp branch from bb271be to a9eff7f Compare May 26, 2023 14:50

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023

openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels May 30, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023

openshift-merge-robot merged commit 5c85a31 into openshift:master Jun 5, 2023

This was referenced Jul 11, 2023

[release-4.13] OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration #371

Closed

[release-4.13] OCPBUGS-15225: Add support for protocolStrategy API field to enable force_tcp configuration #372

Merged

gcs278 mentioned this pull request Aug 7, 2023

[release-4.12] OCPBUGS-15251: Add support for protocolStrategy API field to enable force_tcp configuration #378

Merged

Conversation

gcs278 commented Mar 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Mar 23, 2023

Uh oh!

gcs278 commented Mar 24, 2023

Uh oh!

openshift-ci-robot commented Mar 24, 2023

Uh oh!

openshift-ci-robot commented Mar 24, 2023

Uh oh!

openshift-ci-robot commented Mar 24, 2023

Uh oh!

gcs278 commented Mar 28, 2023

Uh oh!

candita commented Mar 29, 2023

Uh oh!

alebedev87 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alebedev87 Apr 5, 2023

Choose a reason for hiding this comment

Uh oh!

alebedev87 Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gcs278 May 17, 2023

Choose a reason for hiding this comment

Uh oh!

melvinjoseph86 commented May 11, 2023

Uh oh!

melvinjoseph86 commented May 11, 2023

Uh oh!

openshift-ci-robot commented May 17, 2023

Uh oh!

gcs278 commented May 17, 2023

Uh oh!

melvinjoseph86 commented May 26, 2023

Uh oh!

gcs278 commented May 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented May 26, 2023

Uh oh!

Miciah commented May 30, 2023

Uh oh!

openshift-ci Bot commented May 30, 2023

Uh oh!

alebedev87 commented Jun 5, 2023

Uh oh!

openshift-ci-robot commented Jun 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gcs278 commented Mar 23, 2023 •

edited

Loading

alebedev87 left a comment •

edited

Loading

alebedev87 Apr 5, 2023 •

edited

Loading

gcs278 commented May 26, 2023 •

edited

Loading