Skip to content

Add PinnedImageSet#1609

Closed
jhernand wants to merge 2 commits intoopenshift:masterfrom
jhernand:add_pinned_image_set
Closed

Add PinnedImageSet#1609
jhernand wants to merge 2 commits intoopenshift:masterfrom
jhernand:add_pinned_image_set

Conversation

@jhernand
Copy link
Copy Markdown
Contributor

@jhernand jhernand commented Oct 6, 2023

This patch adds a new PinnedImageSet object that describes how to pre-load and pin container images.

Related: openshift/enhancements#1432
Related: https://issues.redhat.com/browse/RFE-4482

@jhernand
Add PinnedImageSet
5d1be08 
This patch adds a new `PinnedImageSet` object that describes how to
pre-load and pin container images.

Related: openshift/enhancements#1432
Related: https://issues.redhat.com/browse/RFE-4482
Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 6, 2023

Hello @jhernand! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 6, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jhernand
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Oct 6, 2023
Merged
Closed
@jhernand
Validate that pinned image references are by digest
c58fe27 
This patch adds a validation to verify that pinned image references are
by digest, as tags aren't allowed.

Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
@petr-muller
Copy link
Copy Markdown
Member

petr-muller commented Oct 20, 2023

/cc

@openshift-ci openshift-ci Bot requested a review from petr-muller October 20, 2023 12:03
@hexfusion hexfusion mentioned this pull request Jan 3, 2024
Closed
@hexfusion
Copy link
Copy Markdown
Contributor

hexfusion commented Jan 3, 2024

continued on #1713

@jhernand jhernand closed this Jan 15, 2024
@hexfusion hexfusion mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhernand @petr-muller @hexfusion