Skip to content

MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet#1822

Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
hexfusion:pinned-image-set
Mar 22, 2024
Merged

MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet#1822
openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
hexfusion:pinned-image-set

Conversation

@hexfusion
Copy link
Copy Markdown
Contributor

@hexfusion hexfusion commented Mar 21, 2024 •
edited
Loading

This PR extends the MachineConfigPool Spec which now takes a list of PinnedImageSetRef and adds a simple PinnedImageSet CRD. More will be needed but this gets the API in the door as MVP while we finalize requirements.

ref:

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 21, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 21, 2024

Hello @hexfusion! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 21, 2024
@hexfusion hexfusion force-pushed the pinned-image-set branch 2 times, most recently from 49f8b63 to 60e5cab Compare March 21, 2024 13:46
@hexfusion hexfusion changed the title machineconfiguration/v1alpha1: add PinnedImageSet MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet Mar 21, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci Bot
Loading

@hexfusion: This pull request references MCO-838 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024
@hexfusion hexfusion mentioned this pull request Mar 21, 2024
Closed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 21, 2024 •
edited by openshift-ci Bot
Loading

@hexfusion: This pull request references MCO-838 which is a valid jira issue.

Details

In response to this:

This PR adds PinnedImageSet types to the machineconfiguration.openshift.io group and a CRD

ref:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 21, 2024

/test all

@hexfusion hexfusion marked this pull request as ready for review March 21, 2024 13:56
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
@openshift-ci openshift-ci Bot requested review from cheesesashimi and deads2k March 21, 2024 14:00
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 21, 2024 •
edited
Loading

ClusterVersion On Update Should be able to add the marketplace capability with a ClusterVersion with base capability None, with the OperatorLifecycleManager capability

Integration failed an OLM test but PinnedImages passed. retesting
ref. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/1822/pull-ci-openshift-api-master-integration/1770811816897679360

/test integration

JoelSpeed
JoelSpeed reviewed Mar 21, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_pinnedimageset.go Outdated
Comment thread machineconfiguration/v1alpha1/custom.pinnedimageset.testsuite.yaml
Comment thread machineconfiguration/v1alpha1/custom.pinnedimageset.testsuite.yaml
@hexfusion hexfusion force-pushed the pinned-image-set branch 2 times, most recently from c50bc8f to 1c6532d Compare March 21, 2024 19:21
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 21, 2024 •
edited
Loading

integration failed from global timeout again PinnedImageSet tests passed I believe this is caused by the additional time tests added in the PR take.

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 22, 2024

/test integration

@hexfusion hexfusion mentioned this pull request Mar 22, 2024
Merged
JoelSpeed
JoelSpeed reviewed Mar 22, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_pinnedimageset.go Outdated
@hexfusion
machineconfiguration/v1alpha1: add PinnedImageSet
bf36a8f 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
machineconfiguration/v1alpha1: add updates per review
744e51f 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
machineconfiguration/v1alpha1: remove newline
2c26a6f 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 22, 2024 •
edited
Loading

Niiice integration tests are speedy.

image

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 22, 2024

@hexfusion: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

JoelSpeed
JoelSpeed reviewed Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Mar 22, 2024

/label acknowledge-critical-fixes-only

This change does not directly contribute to the payload

@openshift-ci openshift-ci Bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 22, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 6e22bae into openshift:master Mar 22, 2024
@hexfusion hexfusion deleted the pinned-image-set branch March 22, 2024 13:59
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Mar 22, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403221545.p0.g6e22bae.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@JoelSpeed JoelSpeed

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hexfusion @openshift-ci-robot @JoelSpeed @openshift-bot