Skip to content

MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet to MCN#1824

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
hexfusion:mcn
Apr 4, 2024
Merged

MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet to MCN#1824
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
hexfusion:mcn

Conversation

@hexfusion
Copy link
Copy Markdown
Contributor

@hexfusion hexfusion commented Mar 22, 2024 •
edited
Loading

This PR adds type support for reporting Node level status of PinnedImageSet through MachineConfigNode Spec and Status.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 22, 2024

Hello @hexfusion! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@openshift-ci openshift-ci Bot requested review from cheesesashimi and jkyros March 22, 2024 03:46
@hexfusion hexfusion changed the title machineconfiguration/v1alpha1: add PinnedImageSet prefetch state progress types MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet prefetch state progress types Mar 22, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 22, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 22, 2024 •
edited by openshift-ci Bot
Loading

@hexfusion: This pull request references MCO-838 which is a valid jira issue.

Details

In response to this:

PinnedImageSets will soon be a first-class citizen of the MachineConfigPool. This PR adds type support for reporting Node status of prefetch and pinning images from a PinnedImageSet through MachineConfigNode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 22, 2024

/cc @cdoern

@openshift-ci openshift-ci Bot requested a review from cdoern March 22, 2024 03:47
@hexfusion hexfusion changed the title MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet prefetch state progress types MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet prefetch StateProgress types Mar 22, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 22, 2024 •
edited by openshift-ci Bot
Loading

@hexfusion: This pull request references MCO-838 which is a valid jira issue.

Details

In response to this:

PinnedImageSets will soon be a first-class citizen of the MachineConfigPool. This PR adds type support for reporting Node status of prefetch and pinning images from a PinnedImageSet through MachineConfigNode

Depends on #1822

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cdoern
cdoern reviewed Mar 22, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
@hexfusion hexfusion changed the title MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet prefetch StateProgress types MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress types Mar 22, 2024
@hexfusion hexfusion changed the title MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress types [wip] MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress types Mar 25, 2024
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 27, 2024 •
edited by openshift-ci Bot
Loading

@hexfusion: This pull request references MCO-838 which is a valid jira issue.

Details

In response to this:

PinnedImageSets will soon be a first-class citizen of the MachineConfigPool. This PR adds type support for reporting Node status of prefetch and pinning images from a PinnedImageSet through MachineConfigNode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 28, 2024
@hexfusion hexfusion changed the title [wip] MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress types MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress types Mar 28, 2024
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 28, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 28, 2024 •
edited by openshift-ci Bot
Loading

@hexfusion: This pull request references MCO-838 which is a valid jira issue.

Details

In response to this:

This PR adds type support for reporting Node level status of PinnedImageSet through MachineConfigNode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cdoern
cdoern approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from an MCO side of things. Adding these into MCN status as an optional field works great.

@hexfusion hexfusion changed the title MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress types MCO-838: machineconfiguration/v1alpha1: add PinnedImageSet StateProgress and Status to MCN Mar 28, 2024
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 28, 2024 •
edited
Loading

/hold going to add full spec/status

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented Mar 29, 2024

/hold cancel

deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go
hexfusion
hexfusion commented Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
hexfusion
hexfusion commented Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
@hexfusion hexfusion force-pushed the mcn branch 3 times, most recently from d973091 to f193760 Compare March 29, 2024 17:44
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
deads2k
deads2k reviewed Mar 29, 2024
View reviewed changes
Comment thread machineconfiguration/v1alpha1/types_machineconfignode.go Outdated
@openshift-ci openshift-ci Bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2024
@hexfusion hexfusion force-pushed the mcn branch 3 times, most recently from f1fd1bc to 53006c7 Compare April 3, 2024 19:51
@hexfusion
machineconfiguration/v1alpha1: add PinnedImageSet to MCN
4db1a8c 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2024

@hexfusion: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 4, 2024

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 96ed2d4 into openshift:master Apr 4, 2024
@hexfusion hexfusion deleted the mcn branch April 4, 2024 20:07
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 5, 2024

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202404041943.p0.g96ed2d4.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@jkyros jkyros Awaiting requested review from jkyros

+1 more reviewer

@cdoern cdoern cdoern approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hexfusion @openshift-ci-robot @deads2k @openshift-bot @cdoern