OCPBUGS-20164: Capability Annotation for Build CRD by adambkaplan · Pull Request #1616 · openshift/api

adambkaplan · 2023-10-11T15:30:29Z

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

JIRA ID: OCPBUGS-20164

Add missing `capability.openshift.io/name` annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

openshift-ci-robot · 2023-10-11T15:30:36Z

@adambkaplan: This pull request references Jira Issue OCPBUGS-20164, which is invalid:

expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

JIRA ID: OCPBUGS-20164

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-10-11T15:30:56Z

Hello @adambkaplan! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

adambkaplan · 2023-10-11T15:57:39Z

Related implementation PR: openshift/cluster-config-operator#360

bparees · 2023-10-11T18:25:34Z

/approve

i know you're still working on this but making sure you're not blocked on the api approval portion anyway.

Annotate the Build CRD so that it is linked with the appropriate cluster capability in the payload empty-resources.

openshift-ci · 2023-10-11T20:56:24Z

@adambkaplan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adambkaplan · 2023-10-12T00:57:17Z

/jira refresh

openshift-ci-robot · 2023-10-12T00:57:20Z

@adambkaplan: This pull request references Jira Issue OCPBUGS-20164, which is invalid:

expected the bug to target the "4.15.0" version, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2023-10-12T03:17:39Z

/jira refresh

openshift-ci-robot · 2023-10-12T03:17:46Z

@bparees: This pull request references Jira Issue OCPBUGS-20164, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.15.0) matches configured target version for branch (4.15.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @coreydaley

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2023-10-12T03:18:02Z

/lgtm

openshift-ci · 2023-10-12T03:18:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2023-10-12T05:07:07Z

Trying to shake Tide loose.

/skip
/retest-required

wking · 2023-10-12T05:16:39Z

/close

openshift-ci · 2023-10-12T05:16:56Z

@wking: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-10-12T05:16:57Z

@adambkaplan: This pull request references Jira Issue OCPBUGS-20164. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

JIRA ID: OCPBUGS-20164

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking · 2023-10-12T05:17:02Z

/reopen

openshift-ci · 2023-10-12T05:17:12Z

@wking: Failed to re-open PR: state cannot be changed. The build-remove-capability branch was force-pushed or recreated.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2023-10-12T14:18:44Z

luckily i think we can consider this PR moot since we now need the rename PR anyway.

OCPBUGS-20164: Capability Annotation for Build CRD

2a218cf

Add missing `capability.openshift.io/name` annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 11, 2023

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2023

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2023

openshift-ci Bot requested review from JoelSpeed and sjenning October 11, 2023 15:32

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023

Add capability to payload command

bc81d14

Annotate the Build CRD so that it is linked with the appropriate cluster capability in the payload empty-resources.

adambkaplan changed the title ~~WIP - OCPBUGS-20164: Capability Annotation for Build CRD~~ OCPBUGS-20164: Capability Annotation for Build CRD Oct 12, 2023

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023

adambkaplan mentioned this pull request Oct 12, 2023

OCPBUGS-20439: Capability Annotation for Build CRD #1617

Merged

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023

openshift-ci Bot requested a review from coreydaley October 12, 2023 03:17

openshift-ci Bot assigned bparees Oct 12, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023

openshift-ci Bot closed this Oct 12, 2023

adambkaplan mentioned this pull request Oct 12, 2023

OCPBUGS-20164: Capabilities fix for Build CRD #1618

Merged

Conversation

adambkaplan commented Oct 11, 2023

Uh oh!

openshift-ci-robot commented Oct 11, 2023

Uh oh!

openshift-ci Bot commented Oct 11, 2023

Uh oh!

adambkaplan commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bparees commented Oct 11, 2023

Uh oh!

openshift-ci Bot commented Oct 11, 2023

Uh oh!

adambkaplan commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

wking commented Oct 12, 2023

Uh oh!

wking commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

wking commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adambkaplan commented Oct 11, 2023 •

edited

Loading