OCPBUGS-20439: Capability Annotation for Build CRD by adambkaplan · Pull Request #1617 · openshift/api

adambkaplan · 2023-10-12T00:59:39Z

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

This is a cherrypick of #1616

Add missing `capability.openshift.io/name` annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

openshift-ci-robot · 2023-10-12T00:59:43Z

@adambkaplan: This pull request references Jira Issue OCPBUGS-20164, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.15" instead
expected Jira Issue OCPBUGS-20164 to depend on a bug targeting a version in 4.15.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

This is a cherrypick of #1616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-10-12T00:59:47Z

Hello @adambkaplan! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

adambkaplan · 2023-10-12T01:17:27Z

Vendor update for cluster-config-operator: openshift/cluster-config-operator#363

openshift-ci · 2023-10-12T01:20:47Z

@adambkaplan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-10-12T01:49:11Z

@adambkaplan: This pull request references Jira Issue OCPBUGS-20439, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.15" instead
expected dependent Jira Issue OCPBUGS-20164 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead
expected dependent Jira Issue OCPBUGS-20164 to target a version in 4.15.0, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

This is a cherrypick of #1616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2023-10-12T01:49:16Z

/jira refresh

openshift-ci-robot · 2023-10-12T01:49:19Z

@bparees: This pull request references Jira Issue OCPBUGS-20439, which is invalid:

expected the bug to target the "4.14.0" version, but it targets "4.15" instead
expected dependent Jira Issue OCPBUGS-20164 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead
expected dependent Jira Issue OCPBUGS-20164 to target a version in 4.15.0, but it targets "4.15" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2023-10-12T01:50:25Z

/jira refresh

openshift-ci-robot · 2023-10-12T01:50:28Z

@bparees: This pull request references Jira Issue OCPBUGS-20439, which is invalid:

expected dependent Jira Issue OCPBUGS-20164 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

bparees · 2023-10-12T01:51:37Z

manually labeling this as valid-bug, we're going to merge out of order (merge to 4.14 first, then follow with 4.15) due to time constraints for getting this into 4.14.0. There is ample time to avoid any regression concerns.

bparees · 2023-10-12T01:53:42Z

/approve
/lgtm
/hold

to be unheld upon completion of cluster-bot testing

openshift-ci · 2023-10-12T01:54:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

bparees · 2023-10-12T03:18:32Z

/hold cancel

openshift-ci-robot · 2023-10-12T03:37:44Z

@adambkaplan: Jira Issue OCPBUGS-20439: Some pull requests linked via external trackers have merged:

openshift/api#1617

The following pull requests linked via external trackers have not merged:

openshift/cluster-config-operator#363 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-20439 has not been moved to the MODIFIED state.

Details

In response to this:

Add missing capability.openshift.io/name annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

This is a cherrypick of #1616

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-10-13T07:35:54Z

Fix included in accepted release 4.14.0-0.nightly-2023-10-13-032002

openshift-merge-robot · 2023-10-13T12:08:30Z

Fix included in accepted release 4.14.0-0.nightly-2023-10-13-073537

openshift-merge-robot · 2023-10-17T13:35:26Z

Fix included in accepted release 4.15.0-0.nightly-2023-10-17-065657

OCPBUGS-20164: Capability Annotation for Build CRD

2931983

Add missing `capability.openshift.io/name` annotation to the Build cluster configuration CRD. This will ensure that the config object for the Build sub-system is not created when the Build capability is not enabled.

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023

openshift-ci Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 12, 2023

openshift-ci Bot requested review from derekwaynecarr and eparis October 12, 2023 01:00

bparees changed the title ~~OCPBUGS-20164: Capability Annotation for Build CRD~~ OCPBUGS-20439: Capability Annotation for Build CRD Oct 12, 2023

bparees added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023

bparees added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 12, 2023

openshift-ci Bot assigned bparees, gangwgr, wangke19 and xingxingxia Oct 12, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023

bparees mentioned this pull request Oct 12, 2023

[release-4.14] OCPBUGS-20439: Remove Build CRD openshift/cluster-config-operator#363

Merged

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 12, 2023

openshift-ci Bot merged commit 434061b into openshift:release-4.14 Oct 12, 2023

adambkaplan mentioned this pull request Oct 12, 2023

[release-4.14] OCPBUGS-20439: Rename manifest for Build CRD #1620

Merged

This was referenced Oct 12, 2023

[release-4.14] OCPBUGS-20439: Include Build CRD in manifests openshift/cluster-openshift-controller-manager-operator#307

Merged

OCPBUGS-20164: Remove Build CRD openshift/cluster-config-operator#360

Merged

Conversation

adambkaplan commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

adambkaplan commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

openshift-ci Bot commented Oct 12, 2023

Uh oh!

bparees commented Oct 12, 2023

Uh oh!

openshift-ci-robot commented Oct 12, 2023

Uh oh!

openshift-merge-robot commented Oct 13, 2023

Uh oh!

openshift-merge-robot commented Oct 13, 2023

Uh oh!

openshift-merge-robot commented Oct 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants