Skip to content

[release-4.14] OCPBUGS-20439: Include Build CRD in manifests#307

Merged
openshift-ci[bot] merged 2 commits intoopenshift:release-4.14from
adambkaplan:build-capability-crd-ocp-4.14
Oct 12, 2023
Merged

[release-4.14] OCPBUGS-20439: Include Build CRD in manifests#307
openshift-ci[bot] merged 2 commits intoopenshift:release-4.14from
adambkaplan:build-capability-crd-ocp-4.14

Conversation

@adambkaplan
Copy link
Copy Markdown
Contributor

Include the build CRD in its manifests. This ensures capabilities are
respected and the build CRD is deployed on the cluster. Also include
an empty-resource instance for "default" installs by the CVO.

Manual cherry-pick of #306

Rename Build CRD yaml so it can be included in ocm-o's manifests.
Include the build CRD in its manifests. This ensures capabilities are
respected and the build CRD is deployed on the cluster. Also include
an empty-resource instance for "default" installs by the CVO.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@adambkaplan: This pull request references Jira Issue OCPBUGS-20439, which is invalid:

  • expected dependent Jira Issue OCPBUGS-20164 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Include the build CRD in its manifests. This ensures capabilities are
respected and the build CRD is deployed on the cluster. Also include
an empty-resource instance for "default" installs by the CVO.

Manual cherry-pick of #306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from bparees and mfojtik October 12, 2023 19:10
@bparees bparees added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 12, 2023
@bparees
Copy link
Copy Markdown
Contributor

bparees commented Oct 12, 2023

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Oct 12, 2023

@adambkaplan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci Bot merged commit d6ded7f into openshift:release-4.14 Oct 12, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@adambkaplan: Jira Issue OCPBUGS-20439: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-20439 has not been moved to the MODIFIED state.

Details

In response to this:

Include the build CRD in its manifests. This ensures capabilities are
respected and the build CRD is deployed on the cluster. Also include
an empty-resource instance for "default" installs by the CVO.

Manual cherry-pick of #306

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan adambkaplan deleted the build-capability-crd-ocp-4.14 branch October 12, 2023 21:36
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-13-032002

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.14.0-0.nightly-2023-10-13-073537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants