NE-2009: Enable GatewayAPI featuregate in Default featureset#2261
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@alebedev87: This pull request references NE-2009 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @alebedev87! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
the
size/S
|
/test verify-feature-promotion To see whether we have more runs now (there were 3 at PR creation). |
|
/test e2e-aws-ovn-techpreview |
|
/test e2e-aws-serial-techpreview |
|
/test verify-feature-promotion |
|
/retest |
|
/test verify-feature-promotion |
|
If you need to trigger additional runs, there's a feature called gangway (search openshift-eng for gangway-cli) that you can use to trigger jobs. I would expect that you have a daily periodic configured, so it should naturally pass at some point |
1 similar comment
|
If you need to trigger additional runs, there's a feature called gangway (search openshift-eng for gangway-cli) that you can use to trigger jobs. I would expect that you have a daily periodic configured, so it should naturally pass at some point |
|
/test e2e-aws-ovn-techpreview Is it this variant ( |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview |
|
@alebedev87: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/70c01eb0-1391-11f0-9552-cccd2fcabc08-0 |
|
/test verify-feature-promotion |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-metal-ipi-ovn-ipv6 |
|
@alebedev87: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
/payload-job ? |
|
@alebedev87: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.19-e2e-metal-ipi-ovn-dualstack-bgp-techpreview |
|
@alebedev87: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
|
Let's see how many runs remain... /test verify-feature-promotion |
|
For the record, this gangway client command can help to get more runs for |
|
Generally we use gangway to trigger 10 runs at a time when trying to gather more data for promotion |
|
/test verify-feature-promotion |
The `openshift-ingress-operator-gatewayapi-crd-admission` Validating Admission Policy is bound to `GatewayAPI` featuregate, which has been promoted to GA (openshift/api#2261). This commit removes the `feature-set` annotation from manifests related to VAP, this effectively makes them part of the `Default` featureset.
The `openshift-ingress-operator-gatewayapi-crd-admission` Validating Admission Policy is bound to `GatewayAPI` featuregate, which has been promoted to GA (openshift/api#2261). This commit removes the `feature-set` annotation from manifests related to VAP, this effectively makes them part of the `Default` featureset.
|
/retest |
|
The non TP e2e tests fail because the VAP is not in Default featureset. |
|
/test verify-feature-promotion |
|
/hold Holding this PR to synchronize the merges with openshift/cluster-ingress-operator#1216. Will unhold this one once the CIO PR is all green and ready to be merged right after this one. Related Slack thread. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/retest-required /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
openshift/cluster-ingress-operator#1216 merged, unholding this one. However, it may take some time to get a build with the change. /unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/retest |
|
I was waiting for the first accepted CI build which contains openshift/cluster-ingress-operator#1216 (which didn't happen) before retesting. But let's see maybe I'm wrong in my assumption. |
|
/retest-required |
|
You think I gave up, CI?! Get some! /retest-required |
|
@alebedev87: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit c38b556
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
TRT-2081: Revert #2261 "NE-2009: Enable GatewayAPI featuregate in Default featureset"
…ote-ga" This reverts commit 088accf.
4 participants
Promote
GatewayAPIfeaturegate which covers the GatewayAPI CRD lifecycle management implemented in the cluster ingress operator.