Skip to content

TRT-2081: Revert #2261 "NE-2009: Enable GatewayAPI featuregate in Default featureset"#2277

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
stbenjam:revert-2261-1744632364109
Apr 14, 2025
Merged

TRT-2081: Revert #2261 "NE-2009: Enable GatewayAPI featuregate in Default featureset"#2277
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
stbenjam:revert-2261-1744632364109

Conversation

@stbenjam
Copy link
Copy Markdown
Member

@stbenjam stbenjam commented Apr 14, 2025 •
edited by openshift-ci Bot
Loading

Reverts #2261 ; tracked by TRT-2081

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift jobs are permafailing after this went ready

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance passes

CC: @alebedev87

PR created by Revertomatic™️

@stbenjam
Revert "Merge pull request openshift#2261 from alebedev87/gwapi-promo…
088accf 
…te-ga"

This reverts commit c38b556, reversing
changes made to 8fcc4e7.
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci Bot
Loading

@stbenjam: This pull request references TRT-2081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #2261 ; tracked by TRT-2081

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift jobs are permafailing after this went ready

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance passes

CC: @alebedev87

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

Hello @stbenjam! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci Bot
Loading

@stbenjam: This pull request references TRT-2081 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Reverts #2261 ; tracked by TRT-2081

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Hypershift jobs are permafailing after this went ready

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

Verify periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn-conformance passes

CC: @alebedev87

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 14, 2025
@openshift-ci openshift-ci Bot requested review from deads2k and everettraven April 14, 2025 12:07
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Apr 14, 2025

/override ci/prow/minor-e2e-upgrade-minor
/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn-techpreview
/label approved

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-techpreview, ci/prow/e2e-upgrade-out-of-change, ci/prow/minor-e2e-upgrade-minor

Details

In response to this:

/override ci/prow/minor-e2e-upgrade-minor
/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn-techpreview
/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Apr 14, 2025

/skip

@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Apr 14, 2025

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-serial, ci/prow/e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xueqzhan
Copy link
Copy Markdown
Contributor

xueqzhan commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stbenjam, xueqzhan
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Apr 14, 2025

/label approved

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@stbenjam
Copy link
Copy Markdown
Member Author

stbenjam commented Apr 14, 2025

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-upgrade
/override ci/prow/minor-e2e-upgrade-minor
/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn-techpreview
/label approved
/skip

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial, ci/prow/e2e-aws-serial-techpreview, ci/prow/e2e-upgrade, ci/prow/e2e-upgrade-out-of-change, ci/prow/minor-e2e-upgrade-minor

Details

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-serial
/override ci/prow/e2e-upgrade
/override ci/prow/e2e-upgrade
/override ci/prow/minor-e2e-upgrade-minor
/override ci/prow/e2e-aws-serial-techpreview
/override ci/prow/e2e-upgrade-out-of-change
/override ci/prow/e2e-aws-ovn-techpreview
/label approved
/skip

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit b7680e1 into openshift:master Apr 14, 2025
23 checks passed
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202504141708.p0.gb7680e1.assembly.stream.el9.
All builds following this will include this PR.

@alebedev87 alebedev87 mentioned this pull request Apr 15, 2025
Merged
@alebedev87 alebedev87 mentioned this pull request Apr 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@xueqzhan xueqzhan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stbenjam @openshift-ci-robot @xueqzhan @openshift-bot