Update KAL to support new guidance on required and optional fields#2440
Conversation
|
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
the
size/XL
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
3 participants
This enforces that all API fields are omitted when unset, and serialized correctly based on whether or not their zero value is a valid user choice.
This update aligns with updated guidance in the upstream API conventions, and downstream (see openshift/enhancements#1825)
This will remove the ability for APIs to be discoverable, by dropping omitempty, the motivation for this change is explained in the linked conventions update above.