MCO-1675: Update API for Status Reporting needs (REBASED)#2442
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@isabella-janssen: This pull request references MCO-1675 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Hello @isabella-janssen! Some important instructions when contributing to openshift/api: |
openshift-ci
Bot
added
the
size/XXL
|
/retitle MCO-1675: Update API for Status Reporting needs (REBASED) |
openshift-ci
Bot
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@isabella-janssen: This pull request references MCO-1675 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/verify-crd-schema False positives, new required field has a new optional parent /test e2e-aws-serial-techpreview-2of2 |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test e2e-aws-ovn-techpreview |
|
@JoelSpeed It looks like the |
|
Overriding the verify-crd-schema check because the new required field is a child of a new optional field. /override ci/prow/verify-crd-schema |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/hold Revision daaca27 was retested 3 times: holding |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
2 similar comments
|
Looks like both the required tests are failing on the known commatrix issue that is unrelated to this change. Overriding. /override ci/prow/e2e-aws-serial-2of2 |
|
@everettraven: Overrode contexts on behalf of everettraven: ci/prow/e2e-aws-serial-2of2, ci/prow/e2e-aws-serial-techpreview-2of2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4 similar comments
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
Bot
merged commit 2f4b91e
into
openshift:master
7 participants
This recreates #2383 with an added commit to resolve the PR's merge conflicts.
Work included
omitemptytag tospec.configImage.desiredImageto meet new validation standard introduced with Update KAL to support new guidance on required and optional fields #2440.