OCPBUGS-74513: OCPBUGS-74519: OCPBUGS-78487: Remove MachineConfigNodes and PinnedImages feature gates and v1alpha1 references

[isabella-janssen]

This removes the MachineConfigNodes and PinnedImages feature gates as well as the v1alpha1 APIs for each, which were replaced with v1 APIs in 4.19 (#2255 & #2198).

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-74513, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This removes the MachineConfigNodes and PinnedImages feature gates and should merge after openshift/machine-config-operator#5609.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f053896a-ec42-4b92-ab65-fcaf13ddf7f7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This pull request removes two feature gates—MachineConfigNodes and PinnedImages—from the codebase. The removal includes deleting the feature gate definitions from the Go code, removing them from multiple feature gate manifest files across different platform configurations, and deleting feature gate annotations from API type definitions. Additionally, the v1alpha1 API definitions for MachineConfigNode and PinnedImageSet are deleted entirely, along with their test files and registration entries. Feature gate references are also cleaned up from CRD test manifests and generated manifests.

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Pull request introduces Ginkgo test code with 62% of assertions lacking meaningful failure messages and 13 cluster operations missing proper timeout handling via Eventually blocks.	Add meaningful failure messages to all Expect assertions and wrap cluster-interactive operations lacking Eventually blocks with proper timeout handling.

✅ Passed checks (7 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically summarizes the main changes: removal of two feature gates (MachineConfigNodes and PinnedImages) and their v1alpha1 API references.
Description check	✅ Passed	The description is directly related to the changeset, explaining what was removed (two feature gates and v1alpha1 APIs) and providing context about why (they were replaced with v1 APIs in 4.19).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names	✅ Passed	The PR does not introduce any Ginkgo test names with dynamic or unstable content. All test names in the modified test YAML files are static and descriptive, clearly indicating what each test validates (e.g., "Should be able to create a minimal MachineConfigNode", "Node name must match the Object name"). No test names contain fmt.Sprintf, variable interpolation, timestamps, UUIDs, pod/node names, or any other values that could change between test runs.
Microshift Test Compatibility	✅ Passed	Shell script searches confirm no new Ginkgo e2e tests are being introduced in this PR; it is exclusively a deprecation/removal PR with no new test patterns.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. The pull request is exclusively a removal/cleanup operation: it removes feature gates, deletes v1alpha1 API type definitions, removes feature gate annotations from v1 types, and cleans up associated test YAML manifests. Since the SNO compatibility check is designed to assess new Ginkgo e2e tests for multi-node assumptions, and no new e2e tests are introduced in this PR, the check is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests; it exclusively removes deprecated API definitions, feature gate entries, and test fixture files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6aa05d40-0c44-11f1-9ce4-4d5ce96c4ea8-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/843dfb40-0c44-11f1-9e48-755722ba80a8-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-1of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4e394a80-0cfe-11f1-9008-fbd59384bacd-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.22-periodics-e2e-aws-mco-disruptive-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/524f9610-0cfe-11f1-8b6a-9e13349dc0d7-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5fc92400-0cfe-11f1-9bf2-4de395b04ad1-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5da83fd0-0cfe-11f1-8b6b-9146d3917b7a-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/633fd430-0cfe-11f1-96e2-6f48c960f3ec-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b4b40c0-0dbf-11f1-8257-094951812dc9-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7da906e0-0dbf-11f1-8e35-60e130204d6c-0

[openshift-ci]

@isabella-janssen: This PR was included in a payload test run from openshift/machine-config-operator#5609
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/804c8890-0dbf-11f1-95a3-c5ba819bee74-0

[JoelSpeed]

/lgtm

Changes here are good when you're ready for this to go

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[isabella-janssen]

/retest-required

[qodo-code-review]

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Remove MachineConfigNodes and PinnedImages feature gates

✨ Enhancement

Walkthroughs

Description

• Remove MachineConfigNodes feature gate definition and references
• Remove PinnedImages feature gate definition and references
• Update feature gate manifest files across all cluster profiles
• Fix indentation inconsistencies in feature gate definitions

Diagram

flowchart LR
  A["Feature Gate Definitions"] -->|Remove MachineConfigNodes| B["Updated features.go"]
  A -->|Remove PinnedImages| B
  B -->|Update documentation| C["features.md"]
  B -->|Update manifests| D["Manifest Files"]
  D -->|8 cluster profile variants| E["Cleaned Feature Gates"]

Loading

File Changes

1. features/features.go ✨ Enhancement +13/-29

Remove two feature gate definitions and fix indentation

features/features.go

---

2. features.md 📝 Documentation +0/-2

Remove feature gate rows from documentation table

features.md

---

3. payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

---

View more (7)

4. payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml

---

5. payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

---

6. payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml

---

7. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

---

8. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml

---

9. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

10. payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml ⚙️ Configuration changes +0/-6

Remove MachineConfigNodes and PinnedImages entries

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (0) 📎 Requirement gaps (0)

1. MachineConfigNodes CRDs filtered out 🐞 Bug ✓ Correctness

Description

MachineConfigNodes is removed from the rendered FeatureGate enabled list, but MachineConfigNode
CRDs/types are still annotated as gated on MachineConfigNodes, so manifest-merge will exclude
those manifests for every FeatureSet/profile. This will change generated CRD outputs (and likely
fail verify-codegen-crds) and can drop MachineConfigNode gated content from rendered payloads.

Code

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[L316-318]

-                    {
-                        "name": "MachineConfigNodes"
-                    },

Evidence

The payload FeatureGate manifest no longer lists MachineConfigNodes as enabled, while the CRD/type
inputs remain annotated with feature-gate.release.openshift.io/MachineConfigNodes. The
manifest-merge filter explicitly includes gated manifests only when all their
feature-gate.release.openshift.io/* annotations are present in the enabled set read from the
payload FeatureGate YAML; verify-codegen-crds runs this generator in verify mode.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[313-342]
machineconfiguration/v1alpha1/types_machineconfignode.go[10-20]
machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/MachineConfigNodes.yaml[4-13]
tools/codegen/pkg/manifestmerge/filters.go[440-475]
tools/codegen/pkg/manifestmerge/filters.go[509-522]
hack/verify-codegen-crds.sh[5-7]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`MachineConfigNodes` was removed from the payload FeatureGate enabled lists, but some CRDs/types are still marked with `+openshift:enable:FeatureGate=MachineConfigNodes` and generated partial manifests still carry `feature-gate.release.openshift.io/MachineConfigNodes`. The manifest-merge generator filters gated manifests by the enabled feature gates from payload FeatureGate YAMLs, so these inputs become unselectable and will change generated outputs / fail `--verify`.

### Issue Context
The intent of this PR is to remove the feature gate entirely (i.e., feature becomes unconditional). That requires removing the API/CRD gating markers as well and regenerating the derived manifests.

### Fix Focus Areas
- machineconfiguration/v1alpha1/types_machineconfignode.go[10-20]
- machineconfiguration/v1/types_machineconfignode.go[10-20]
- machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/MachineConfigNodes.yaml[4-13]
- tools/codegen/pkg/manifestmerge/filters.go[440-475]

After removing the gating markers, run the repo’s CRD codegen update (the same generators used by `hack/verify-codegen-crds.sh`) and commit the updated generated outputs (including any featuregated test cases that still mention `MachineConfigNodes`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. PinnedImages CRDs filtered out 🐞 Bug ✓ Correctness

Description

PinnedImages is removed from the rendered FeatureGate enabled list, but several APIs/CRD partial
manifests are still gated on PinnedImages, so manifest-merge will exclude those manifests for
every FeatureSet/profile. This will change generated CRD outputs (and likely fail
verify-codegen-crds) and can drop pinned-images related schema/CRDs from rendered payloads.

Code

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[L340-342]

-                    {
-                        "name": "PinnedImages"
-                    },

Evidence

The payload FeatureGate manifest no longer lists PinnedImages as enabled, but the pinned-images
APIs and CRD partials still include +openshift:enable:FeatureGate=PinnedImages and
feature-gate.release.openshift.io/PinnedImages. The manifest-merge filter includes a manifest only
if its feature-gate.release.openshift.io/* annotations are all present in the enabled set loaded
from the payload FeatureGate YAML.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml[331-342]
machineconfiguration/v1alpha1/types_pinnedimageset.go[10-20]
machineconfiguration/v1/types.go[440-455]
machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/pinnedimagesets.machineconfiguration.openshift.io/PinnedImages.yaml[4-13]
machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/PinnedImages.yaml[4-12]
tools/codegen/pkg/manifestmerge/filters.go[509-522]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The `PinnedImages` feature gate was removed from the payload FeatureGate enabled lists, but several APIs/CRD partial manifests are still gated on `PinnedImages` via `+openshift:enable:FeatureGate=PinnedImages` and `feature-gate.release.openshift.io/PinnedImages`. The manifest-merge generator filters gated manifests by the enabled feature gates from payload FeatureGate YAMLs, so these manifests become unselectable and will change generated outputs / fail `--verify`.

### Issue Context
If `PinnedImages` is intended to be always-on, remove the gating markers and regenerate the CRD outputs so the schema/CRDs are no longer conditioned on a non-existent feature gate.

### Fix Focus Areas
- machineconfiguration/v1alpha1/types_pinnedimageset.go[10-20]
- machineconfiguration/v1/types.go[440-548]
- machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/pinnedimagesets.machineconfiguration.openshift.io/PinnedImages.yaml[4-13]
- machineconfiguration/v1/zz_generated.featuregated-crd-manifests/machineconfigpools.machineconfiguration.openshift.io/PinnedImages.yaml[4-12]
- tools/codegen/pkg/manifestmerge/filters.go[440-475]

After removing the gating markers, run the CRD generators invoked by `hack/verify-codegen-crds.sh` and commit updated generated files (including any featuregated tests that still list `PinnedImages`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

ⓘ The new review experience is currently in Beta. Learn more

[qodo-code-review]

1. Machineconfignodes crds filtered out 🐞 Bug ✓ Correctness

MachineConfigNodes is removed from the rendered FeatureGate enabled list, but MachineConfigNode
CRDs/types are still annotated as gated on MachineConfigNodes, so manifest-merge will exclude
those manifests for every FeatureSet/profile. This will change generated CRD outputs (and likely
fail verify-codegen-crds) and can drop MachineConfigNode gated content from rendered payloads.

Agent Prompt

### Issue description
`MachineConfigNodes` was removed from the payload FeatureGate enabled lists, but some CRDs/types are still marked with `+openshift:enable:FeatureGate=MachineConfigNodes` and generated partial manifests still carry `feature-gate.release.openshift.io/MachineConfigNodes`. The manifest-merge generator filters gated manifests by the enabled feature gates from payload FeatureGate YAMLs, so these inputs become unselectable and will change generated outputs / fail `--verify`.

### Issue Context
The intent of this PR is to remove the feature gate entirely (i.e., feature becomes unconditional). That requires removing the API/CRD gating markers as well and regenerating the derived manifests.

### Fix Focus Areas
- machineconfiguration/v1alpha1/types_machineconfignode.go[10-20]
- machineconfiguration/v1/types_machineconfignode.go[10-20]
- machineconfiguration/v1alpha1/zz_generated.featuregated-crd-manifests/machineconfignodes.machineconfiguration.openshift.io/MachineConfigNodes.yaml[4-13]
- tools/codegen/pkg/manifestmerge/filters.go[440-475]

After removing the gating markers, run the repo’s CRD codegen update (the same generators used by `hack/verify-codegen-crds.sh`) and commit the updated generated outputs (including any featuregated test cases that still mention `MachineConfigNodes`).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

[isabella-janssen]

/test verify
/test verify-deps
/test integration

[JoelSpeed]

Needs a rebase to fix the conflict, but otherwise LGTM

[isabella-janssen]

/payload-job periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2 periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2 periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3 periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3 periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

For verification

[openshift-ci]

@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2
• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a37b9e80-213f-11f1-8e6e-842d08329e23-0

[openshift-ci]

@isabella-janssen: trigger 5 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-1of2
• periodic-ci-openshift-machine-config-operator-release-4.21-periodics-e2e-aws-mco-disruptive-techpreview-2of2
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-1of3
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-2of3
• periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ab5e8270-213f-11f1-8424-3fec109cc418-0

[JoelSpeed]

/lgtm

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[isabella-janssen]

/verified by payloads

Payload rehearsals look good; the failure in periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3 seem unrelated to this PR and the MCO disruptive suites are unstable currently #2715 (comment)

[openshift-ci-robot]

@isabella-janssen: This PR has been marked as verified by payloads.

Details

In response to this:

/verified by payloads

Payload rehearsals look good; the failure in periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-techpreview-serial-3of3 seem unrelated to this PR and the MCO disruptive suites are unstable currently #2715 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/retest-required

[openshift-ci]

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-74513
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74513 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This removes the MachineConfigNodes and PinnedImages feature gates as well as the v1alpha1 APIs for each, which were replaced with v1 APIs in 4.19 (#2255 & #2198).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.