TRT-2578: Revert "OCPBUGS-74513: OCPBUGS-74519: OCPBUGS-78487: Remove MachineConfigNodes and PinnedImages feature gates and v1alpha1 references"#2767
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@smg247: This pull request references Jira Issue OCPBUGS-74513, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @smg247! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (10)
📒 Files selected for processing (27)
📝 WalkthroughWalkthroughThis pull request introduces two new OpenShift feature gates: MachineConfigNodes and PinnedImages. It adds corresponding Kubernetes Custom Resource Definitions (CRDs) in the v1alpha1 API group, including MachineConfigNode, MachineConfigNodeList, PinnedImageSet, and PinnedImageSetList types. Feature gate annotations are applied to various fields in v1 and v1alpha1 types. The changes include generated deepcopy methods, Swagger documentation, feature-gated CRD manifests, and test fixtures. Feature gate enablement is configured across multiple deployment profiles including Hypershift and SelfManagedHA environments. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.3)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-upgrade 10 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4dfd2dc0-21f8-11f1-9cf7-049dfc073143-0 |
MachineConfigNodes and PinnedImages feature gates and v1alpha1 references"MachineConfigNodes and PinnedImages feature gates and v1alpha1 references"
|
@smg247: This pull request references TRT-2578 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold for payload job verification |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade 10 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/75fc36c0-21fa-11f1-9262-6f83fb5cd30a-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-upgrade 10 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c99a28a0-21fa-11f1-8a96-867fbc82dd8b-0 |
|
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn-upgrade 10 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2f52ae30-2203-11f1-803a-98d0f07118c2-0 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade 10 |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-e2e-gcp-ovn-upgrade 10 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a559fb60-2203-11f1-838a-9bd172f7a6f5-0 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a14361b0-2203-11f1-8840-e041823f2467-0 |
|
/pipeline required |
|
Scheduling tests matching the |
|
/payload-aggregate periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade 5 |
|
@stbenjam: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7229e980-2230-11f1-9248-3bce635088b4-0 |
|
We're not super confident about this revert, we're still investigating. It is not a permafail, in the originating payload it only showed up a few times, however these errors have never occurred, according to Sippy's 3 month history. I also know kubelet service file is somehow tied in with which FG's are enabled, but unfortunately from what I can tell we sanitize this in our CI must gathers. That all said... I'm going to tag this so its ready to go in case we need it Lint is erroneous because this was existing code (and lint checks PR diff only in this repo) /hold |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/lint, ci/prow/verify-feature-promotion DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: stbenjam The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
https://amd64.ocp.releases.ci.openshift.org/releasestream/4.22.0-0.ci/release/4.22.0-0.ci-2026-03-17-150535 was accepted. We'll keep an eye on the problem. |
|
registry.ci outage - and then MCO failed to roll back. Not this PR! |
This reverts #2715
Why the revert?
This PR is causing blocking job failures (aggregated-aws-ovn-upgrade, aggregated-azure-ovn-upgrade, aggregated-gcp-ovn-upgrade) in the ci amd64 payload 4.22.0-0.ci-2026-03-17-030533.
Evidence
Tracking
To unrevert
/cc @isabella-janssen
To restore your change, please:
🤖 Generated with Revertomatic