Skip to content

simplify operatorspec to match what we ended up needing#285

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:operator-reality
Apr 11, 2019
Merged

simplify operatorspec to match what we ended up needing#285
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
deads2k:operator-reality

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Apr 11, 2019

We are able to simplify the operator spec based on what has actually been necessary.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@derekwaynecarr
Copy link
Copy Markdown
Member

/approve

@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, derekwaynecarr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [deads2k,derekwaynecarr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread operator/v1/types.go Outdated
type StaticPodOperatorSpec struct {
OperatorSpec `json:",inline"`

// forceRedeploymentReason can be used to force the redeployment of the kube-controller-manager by providing a unique string.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste of kube-controller-manager

Comment thread operator/v1/types.go

// operandSpecs provide customization for functional units within the component
// +optional
OperandSpecs []OperandSpec `json:"operandSpecs,omitempty"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we simply do not want support for applying a patch on the operand's deployment/pod?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we simply do not want support for applying a patch on the operand's deployment/pod?

We don't today. We'll see what we need later

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 8f991bd into openshift:master Apr 11, 2019
@Miciah
Copy link
Copy Markdown
Contributor

Miciah commented Apr 11, 2019

Should delete

// forceRedeploymentReason can be used to force the redeployment of the kube-apiserver by providing a unique string.
// This provides a mechanism to kick a previously failed deployment and provide a reason why you think it will work
// this time instead of failing again on the same config.
ForceRedeploymentReason string `json:"forceRedeploymentReason"`
too, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants