bump(*) by coreydaley · Pull Request #86 · openshift/cluster-openshift-controller-manager-operator

coreydaley · 2019-04-10T15:57:29Z

Includes bump due to openshift/api#285
changes to use go-bindata/go-bindata
updates to use klog

coreydaley · 2019-04-10T16:02:52Z

/assign @adambkaplan

New pull request to bump deps

adambkaplan

Looks like api and client-go bumps weren't clean.

If we're upgrading api and client-go to master, we must also update the kube pins to point to 1.13 tags/branches.

coreydaley · 2019-04-10T20:11:34Z

/retest

aws_vpc.new_vpc: Error creating VPC: VpcLimitExceeded: The maximum number of VPCs has been reached.

coreydaley · 2019-04-10T20:52:52Z

@adambkaplan ptal

coreydaley · 2019-04-11T14:12:12Z

@adambkaplan ptal

coreydaley · 2019-04-11T17:09:33Z

/retest

failed to initialize the cluster: Working towards 0.0.1-2019-04-11-160713: 91% complete: timed out waiting for the condition

coreydaley · 2019-04-11T18:07:18Z

/retest

coreydaley · 2019-04-11T19:46:21Z

/retest

coreydaley · 2019-04-11T23:46:26Z

/retest

coreydaley · 2019-04-12T01:10:58Z

/retest

coreydaley · 2019-04-12T10:56:59Z

/retest

coreydaley · 2019-04-12T15:00:15Z

/retest

coreydaley · 2019-04-12T15:37:17Z

/retest

coreydaley · 2019-04-12T16:07:32Z

/retest

adambkaplan

looks good, but want @deads2k to take another pass before signing off.

/approve

coreydaley · 2019-04-12T16:47:01Z

/retest

adambkaplan · 2019-04-12T20:02:37Z

/hold

Other control plane operators are not on golang 1.11

coreydaley · 2019-04-15T01:45:39Z

/retest

coreydaley · 2019-04-15T16:19:33Z

@adambkaplan ptal, dropped the go1.11 commit

adambkaplan · 2019-04-15T16:26:18Z

/hold cancel

adambkaplan · 2019-04-15T16:26:33Z

/lgtm

coreydaley · 2019-04-15T21:22:24Z

/retest

openshift-bot · 2019-04-15T22:57:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

coreydaley · 2019-04-15T23:58:21Z

/retest

coreydaley · 2019-04-16T00:02:04Z

/retest

could not copy stable imagestreamtag: Timeout: request did not complete within allowed duration

openshift-bot · 2019-04-16T12:24:15Z

/retest

Please review the full test history for this PR and help us cut down flakes.

coreydaley · 2019-04-16T14:18:18Z

/retest

coreydaley · 2019-04-16T19:33:16Z

/retest

coreydaley · 2019-04-16T22:29:24Z

/retest

coreydaley · 2019-04-17T02:32:56Z

/retest

openshift-bot · 2019-04-17T06:36:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-17T16:07:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-04-17T17:40:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

coreydaley · 2019-04-17T18:34:59Z

/hold
needs another dependency bump when library-go pr has merged openshift/library-go#354

coreydaley · 2019-04-18T14:53:41Z

/hold cancel

coreydaley · 2019-04-18T17:19:49Z

/retest

level=error msg="\t* module.vpc.aws_route.to_nat_gw[1]: 1 error occurred:"
level=error msg="\t* aws_route.to_nat_gw.1: Error creating route: timeout while waiting for state to become 'success' (timeout: 2m0s)"

coreydaley · 2019-04-18T17:20:18Z

@adambkaplan ptal, I think I got it this time, the last failure was a cluster installation issue

adambkaplan · 2019-04-18T17:35:24Z

/lgtm

openshift-ci-robot · 2019-04-18T17:35:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 10, 2019

openshift-ci-robot requested review from adambkaplan and deads2k April 10, 2019 15:57

openshift-ci-robot assigned adambkaplan Apr 10, 2019

adambkaplan requested changes Apr 10, 2019

View reviewed changes

Comment thread glide.lock Outdated

deads2k reviewed Apr 12, 2019

View reviewed changes

Comment thread glide.yaml

deads2k reviewed Apr 12, 2019

View reviewed changes

Comment thread glide.yaml Outdated

adambkaplan approved these changes Apr 12, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2019

adambkaplan mentioned this pull request Apr 12, 2019

Update to use go1.11 for controller-manager-operator openshift/release#3455

Merged

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 17, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019

coreydaley added 2 commits April 18, 2019 11:58

bump(*)

f49b2f8

updates due to dependency bump

b30dbfe

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2019

openshift-merge-robot merged commit 04a593c into openshift:master Apr 18, 2019

Conversation

coreydaley commented Apr 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coreydaley commented Apr 10, 2019

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coreydaley commented Apr 10, 2019

Uh oh!

coreydaley commented Apr 10, 2019

Uh oh!

coreydaley commented Apr 11, 2019

Uh oh!

coreydaley commented Apr 11, 2019

Uh oh!

coreydaley commented Apr 11, 2019

Uh oh!

coreydaley commented Apr 11, 2019

Uh oh!

coreydaley commented Apr 11, 2019

Uh oh!

coreydaley commented Apr 12, 2019

Uh oh!

coreydaley commented Apr 12, 2019

Uh oh!

Uh oh!

Uh oh!

coreydaley commented Apr 12, 2019

Uh oh!

coreydaley commented Apr 12, 2019

Uh oh!

coreydaley commented Apr 12, 2019

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

coreydaley commented Apr 12, 2019

Uh oh!

adambkaplan commented Apr 12, 2019

Uh oh!

coreydaley commented Apr 15, 2019

Uh oh!

coreydaley commented Apr 15, 2019

Uh oh!

adambkaplan commented Apr 15, 2019

Uh oh!

adambkaplan commented Apr 15, 2019

Uh oh!

coreydaley commented Apr 15, 2019

Uh oh!

openshift-bot commented Apr 15, 2019

Uh oh!

coreydaley commented Apr 15, 2019

Uh oh!

coreydaley commented Apr 16, 2019

Uh oh!

openshift-bot commented Apr 16, 2019

Uh oh!

coreydaley commented Apr 16, 2019

Uh oh!

coreydaley commented Apr 16, 2019

Uh oh!

coreydaley commented Apr 16, 2019

Uh oh!

coreydaley commented Apr 17, 2019

Uh oh!

openshift-bot commented Apr 17, 2019

Uh oh!

openshift-bot commented Apr 17, 2019

Uh oh!

openshift-bot commented Apr 17, 2019

Uh oh!

coreydaley commented Apr 17, 2019

Uh oh!

coreydaley commented Apr 18, 2019

Uh oh!

coreydaley commented Apr 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

coreydaley commented Apr 10, 2019 •

edited

Loading

coreydaley commented Apr 18, 2019 •

edited

Loading