Skip to content

Change ClusterOperatorStatus Failed to Degraded#354

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
eparis:fail-to-degraded
Apr 18, 2019
Merged

Change ClusterOperatorStatus Failed to Degraded#354
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
eparis:fail-to-degraded

Conversation

@eparis
Copy link
Copy Markdown
Member

@eparis eparis commented Apr 17, 2019 •
edited
Loading

This is just a rename, but it should take on a slightly newer definition over time.

openshift/cluster-version-operator#161

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 17, 2019
@eparis eparis force-pushed the fail-to-degraded branch 3 times, most recently from 5cf2fe1 to 30ba04b Compare April 17, 2019 02:53
@openshift-ci-robot openshift-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 17, 2019
@eparis eparis force-pushed the fail-to-degraded branch from 30ba04b to 86764c7 Compare April 17, 2019 03:09
eparis
eparis commented Apr 17, 2019
View reviewed changes
Comment thread glide.yaml
package: github.com/openshift/library-go
import:
- package: k8s.io/apimachinery
version: kubernetes-1.13.4
Copy link
Copy Markdown
Member Author

@eparis eparis Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how the heck was this not already pinned? do you know how long it took me to figure out this was my problem? I've gotten so dumb.

Copy link
Copy Markdown
Contributor

@deads2k deads2k Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how the heck was this not already pinned? do you know how long it took me to figure out this was my problem? I've gotten so dumb.

Clearly that guy should be fired.

@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

@deads2k

@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

based on openshift/api#287

@eparis eparis force-pushed the fail-to-degraded branch from 86764c7 to d695467 Compare April 17, 2019 14:52
@eparis eparis changed the title [wip] Fail to degraded Fail to degraded Apr 17, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2019
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 17, 2019

everybody jump!

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, eparis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@eparis eparis changed the title Fail to degraded Change ClusterOperatorStatus Failed to Degraded Apr 17, 2019
@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

/hold
probably shouldn't jump until:
openshift/cluster-version-operator#165

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2019
@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

/retest

@eparis
Copy link
Copy Markdown
Member Author

eparis commented Apr 17, 2019

see: openshift/api#287

@deads2k deads2k mentioned this pull request Apr 17, 2019
Merged
@coreydaley coreydaley mentioned this pull request Apr 17, 2019
Merged
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 18, 2019

/hold cancel

running for API freeze, the CVO will take the update eventually, releasing this

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit 7dbda73 into openshift:master Apr 18, 2019
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
@openshift-merge-robot
Merge pull request openshift#354 from eparis/fail-to-degraded
00c6e28 
Change ClusterOperatorStatus Failed to Degraded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eparis @deads2k @openshift-ci-robot @openshift-merge-robot