Change Failed to Degraded#165
Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom Apr 18, 2019
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
Member
Author
|
Based on: openshift/api#287 |
eparis
force-pushed
the
failed-to-degraded
branch
10 times, most recently
from
f1a8c6c to
54ed420
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
docs PR: #161 |
Member
Author
|
see: openshift/api#287 |
smarterclayton
suggested changes
Apr 17, 2019
Contributor
smarterclayton
left a comment
smarterclayton
left a comment
There was a problem hiding this comment.
What did you use to update? make vendor?
eparis
force-pushed
the
failed-to-degraded
branch
from
54ed420 to
51d66be
Compare
Member
Author
|
Updating vendor was via: |
eparis
force-pushed
the
failed-to-degraded
branch
from
51d66be to
7e7f31a
Compare
This is so we can use --args --alsologtostderr for all integration tests
eparis
force-pushed
the
failed-to-degraded
branch
from
7e7f31a to
73179c1
Compare
Member
Author
|
/retest |
Contributor
|
This looks ok to me but want @abhinavdahiya to take a look if he can tomorrow. |
Contributor
|
/test all |
Contributor
|
Ok, will deal with fallout in separate issues /lgtm |
smarterclayton
approved these changes
Apr 18, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Apr 22, 2019
…ing -> Degraded Fix [1]: $ oc get clusteroperators kube-apiserver NAME VERSION AVAILABLE PROGRESSING FAILING SINCE kube-apiserver 4.1.0-0.nightly-2019-04-22-005054 True False 20m when the ClusterOperator only sets Degraded. This should have happened in 94c4e57 (Use the new degraded condition is available, 2019-04-16, openshift#165). [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1702087
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Apr 23, 2019
…Degraded Fix [1]: $ oc get clusteroperators kube-apiserver NAME VERSION AVAILABLE PROGRESSING FAILING SINCE kube-apiserver 4.1.0-0.nightly-2019-04-22-005054 True False 20m when the ClusterOperator only sets Degraded. This should have happened in 94c4e57 (Use the new degraded condition is available, 2019-04-16, openshift#165). There may be some JSONPath syntax to collapse both into a single column: .status.conditions[?(@.type IN ["Degraded", "Failing"])].status but if it exists, I haven't discovered it. We can drop the Failing column once all the operators have migrated. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1702087
wking
added a commit
to wking/cluster-version-operator
that referenced
this pull request
Apr 23, 2019
…aded -> Failing Fix [1]: $ oc get clusteroperators kube-apiserver NAME VERSION AVAILABLE PROGRESSING FAILING SINCE kube-apiserver 4.1.0-0.nightly-2019-04-22-005054 True False 20m when the ClusterOperator only sets Degraded. This should have happened in 94c4e57 (Use the new degraded condition is available, 2019-04-16, openshift#165). There may be some JSONPath syntax to collapse both into a single column: .status.conditions[?(@.type IN ["Degraded", "Failing"])].status but if it exists, I haven't discovered it. We're hopefully going to fix the operators that are still using Failing soon, so just skip to the new field without supporting both [2]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1702087 [2]: openshift#172 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.