Bug 1702087: install/0000_00_cluster-version-operator_01_clusteroperator.crd: Failing -> Degraded

[wking]

Fix:

$ oc get clusteroperators kube-apiserver
NAME             VERSION                             AVAILABLE   PROGRESSING   FAILING   SINCE
kube-apiserver   4.1.0-0.nightly-2019-04-22-005054   True        False                   20m

when the ClusterOperator only sets Degraded. This should have happened in 94c4e57 (#165).

[wking]

CC @eparis, @smarterclayton, since I'm blaming #165 ;)

[smarterclayton]

/lgtm

We need to add a cli e2e for this

[abhinavdahiya]

/hold

[wking]

If we want to support both Failing and Degraded during the transition, I'm fine with that. I'm not quite clear on how though. We can certainly retain two columns here, and I can update the PR accordingly. But if we wanted to collapse both into the same column (with the collapsing logic like we have in Go in #165), I'll need some pointers for JSONPath syntax. Since I have a pod listing handy, I've been experimenting there without success to try to find a boolean or expression supported by oc:

$ oc get -o jsonpath='{.items[*].status.conditions[?(@.type == "Initialized" or @.Type == "Ready")]}' pods
error: error parsing jsonpath {.items[*].status.conditions[?(@.type == "Initialized" or @.Type == "Ready")]}, unrecognized character in action: U+003D '='
$ oc get -o jsonpath='{.items[*].status.conditions[?(@.type == "Initialized"), ?(@.Type == "Ready")]}' pods
error: error parsing jsonpath {.items[*].status.conditions[?(@.type == "Initialized"), ?(@.Type == "Ready")]}, unclosed array expect ]
$ oc get -o jsonpath='{.items[*].status.conditions[?(@.type == "Initialized" || @.Type == "Ready")]}' pods
error: error parsing jsonpath {.items[*].status.conditions[?(@.type == "Initialized" || @.Type == "Ready")]}, unrecognized character in action: U+007C '|'

[wking]

I've pushed 7f743ef -> df68d7b to go with the two-column approach until I get more feedback ;).

[smarterclayton]

I don't see a ton of value in two columns. We won't ship with failing and it's dead code. It would be better to open PRs against other components and fix their "Failing" strings :)

…

On Mon, Apr 22, 2019 at 8:09 PM W. Trevor King ***@***.***> wrote: I've pushed 7f743ef <7f743ef> -> df68d7b <df68d7b> to go with the two-column approach until I get more feedback ;). — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#172 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI37J36PAQ7S6M3ZOD5DSDPRZHUBANCNFSM4HHTKHXA> .

[wking]

Ok, back to Failing -> Degraded (instead of supporting both) with df68d7b -> 3142181.

[eparis]

/lgtm
/hold cancel
Agree, one column, bugs for anything not reporting

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [smarterclayton,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eparis]

/retest
/hold cancel