Skip to content

Add UpdateStaticPodOperatorSpec function#355

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
damemi:update-staticpodop-spec
Apr 22, 2019
Merged

Add UpdateStaticPodOperatorSpec function#355
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
damemi:update-staticpodop-spec

Conversation

@damemi
Copy link
Copy Markdown

@damemi damemi commented Apr 17, 2019

My use case: writing an e2e test for revision pruning, want to trigger a bunch of new revisions by updating the ForceRedeploymentReason in StaticPodOperatorSpec. Currently we can get the spec but I don't know of any way to update it.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2019
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 17, 2019

squash, then lgtm

You must wait until after #354

@damemi damemi force-pushed the update-staticpodop-spec branch from 8fd6055 to 75a9272 Compare April 17, 2019 16:00
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Apr 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2019
@openshift-merge-robot openshift-merge-robot merged commit a47c681 into openshift:master Apr 22, 2019
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants