Update to use go1.11 for controller-manager-operator#3455
Update to use go1.11 for controller-manager-operator#3455openshift-merge-robot merged 1 commit intoopenshift:masterfrom coreydaley:update_controller_manager_to_use_go1_11
Conversation
openshift-ci-robot
added
the
size/XS
|
/assign @adambkaplan |
|
@coreydaley need go1.11 for release-4.0 as well. For reasons both branches are synced with master. |
|
@adambkaplan updated, ptal |
|
Also may need to run prow-gen: https://github.com/openshift/release/blob/master/ci-operator/README.md#ci-operator |
|
/retest @adambkaplan ran the prow-gen locally and there were no errors or changes (only warnings about names longer than 63 chars) |
|
/retest |
|
/lgtm based on other golang bumps /assign @bparees |
|
/hold Have the rest of the control plane not bumped api and client-go? |
openshift-ci-robot
added
the
do-not-merge/hold
|
dunno. but also i'd expect this to be where you made the change to use go1.11? https://github.com/openshift/cluster-kube-apiserver-operator/blob/master/Dockerfile.rhel7#L1 |
|
well i guess that FROM will be substituted somewhere in the process, but it should probably be updated regardless as part of this. |
|
we already have a PR to update the golang in the Dockerfile - openshift/cluster-openshift-controller-manager-operator#86 |
|
@stevekuznetsov can you weigh in here on what this does? |
|
Even after updating the Dockerfile to use go1.11, the tests are still using go1.10. |
|
/retest |
|
@soltysh Do we need to let this merge now due to openshift/cluster-openshift-controller-manager-operator#89 ? |
I'm not sure about 4.0 and 4.1 branches, yet. For now I'd stick with just master. |
|
@soltysh thanks! @adambkaplan updated per suggestions from @soltysh, ptal |
|
/hold cancel /lgtm |
openshift-ci-robot
added
lgtm
|
🤦♂️ and I thought I did that in #3489 |
|
@soltysh You did openshift-cluster-kube-controller-manager-operator-master.yaml |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
I know, that's why the 🤦♂️ 😝 |
soltysh
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: adambkaplan, coreydaley The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@coreydaley: Updated the following 2 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@coreydaley: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
No description provided.