Skip to content

Switch openshift/ocm-o to go1.11#89

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:go1.11
Apr 17, 2019
Merged

Switch openshift/ocm-o to go1.11#89
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:go1.11

Conversation

@soltysh
Copy link
Copy Markdown

@soltysh soltysh commented Apr 16, 2019

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2019
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 16, 2019

/retest
/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2019
@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 16, 2019

/retest

2 similar comments
@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 16, 2019

/retest

@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 16, 2019

/retest

@coreydaley coreydaley mentioned this pull request Apr 16, 2019
Merged
@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Apr 16, 2019

For clarity the golang builder in the Dockerfiles should be changed to golang-1.11
https://github.com/openshift/cluster-openshift-controller-manager-operator/blob/master/Dockerfile#L1
https://github.com/openshift/cluster-openshift-controller-manager-operator/blob/master/Dockerfile.rhel7#L1

@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 16, 2019

@adambkaplan good point, lemme update those right away

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 16, 2019

@adambkaplan mind re-tagging

@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Apr 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 16, 2019

/retest

3 similar comments
@coreydaley
Copy link
Copy Markdown

coreydaley commented Apr 16, 2019

/retest

@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 17, 2019

/retest

@soltysh
Copy link
Copy Markdown
Author

soltysh commented Apr 17, 2019

/retest

@coreydaley
Copy link
Copy Markdown

coreydaley commented Apr 17, 2019

I am working to address this test failure in #87 , just an FYI

@coreydaley
Copy link
Copy Markdown

coreydaley commented Apr 17, 2019

/retest

@openshift-merge-robot openshift-merge-robot merged commit ea88b18 into openshift:master Apr 17, 2019
@soltysh soltysh deleted the go1.11 branch April 19, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@sttts sttts

@adambkaplan adambkaplan

@tnozicka tnozicka

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@soltysh @sttts @adambkaplan @openshift-ci-robot @coreydaley @tnozicka @openshift-merge-robot