Skip to content

A little bit of clean up#87

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
coreydaley:a_few_fixes
Apr 17, 2019
Merged

A little bit of clean up#87
openshift-merge-robot merged 1 commit into
openshift:masterfrom
coreydaley:a_few_fixes

Conversation

@coreydaley
Copy link
Copy Markdown

@coreydaley coreydaley commented Apr 15, 2019 •
edited
Loading

  • all receivers should have the same name
  • copy is a reserved word
  • variable collides with imported package name
  • removing unused variable
  • fixing test to update instead of create/delete

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 15, 2019

/assign @adambkaplan

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2019
@adambkaplan
Copy link
Copy Markdown
Contributor

adambkaplan commented Apr 15, 2019

/approve

Squash commits, then I will lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2019
@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 15, 2019

@adambkaplan squashed.

adambkaplan
adambkaplan approved these changes Apr 15, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2019
@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 15, 2019

/retest

2 similar comments
@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 15, 2019

/retest

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 15, 2019

/retest

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 15, 2019

At this point, I feel like it's a flake if all of the tests DO pass.

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 16, 2019

/retest

could not wait for build: the build cluster-openshift-controller-manager-operator failed after 1m10s with reason PullBuilderImageFailed: Failed pulling builder image.

Pulling image docker-registry.default.svc:5000/ci-op-cc7x0...e6ae8cbd1522cd7226cff89629c21a3652f6fd57d84f405d432c07a ...
error: build error: failed to pull image: Get https://dock...t canceled (Client.Timeout exceeded while awaiting headers)

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 16, 2019

/retest
could not wait for build: could not find build cluster-openshift-controller-manager-operator

:(

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 16, 2019

/retest

3 similar comments
@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 16, 2019

/retest

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 16, 2019

/retest

@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 16, 2019

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@coreydaley coreydaley mentioned this pull request Apr 17, 2019
Merged
@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 17, 2019

@adambkaplan ptal, had to update the test to update instead of delete as the resource already exists

adambkaplan
adambkaplan requested changes Apr 17, 2019
View reviewed changes
Comment thread test/e2e/cluster_openshift_controller_manager_operator_test.go
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@coreydaley
all receivers should have the same name
4d9859b 
copy is a reserved word

variable collides with imported package name

removing unused variable

fixing test to update instead of create/delete
@coreydaley
Copy link
Copy Markdown
Author

coreydaley commented Apr 17, 2019

@adambkaplan ptal, fixed the test and everything is passing now

adambkaplan
adambkaplan approved these changes Apr 17, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, coreydaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit bdb533f into openshift:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@adambkaplan adambkaplan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coreydaley @adambkaplan @openshift-ci-robot @openshift-merge-robot