Add UseMDNS member to baremetal platform status#522
Add UseMDNS member to baremetal platform status#522cybertron wants to merge 1 commit intoopenshift:masterfrom
Conversation
We've had new use cases presented where our mDNS services cannot be used and are not needed, so we need a way to disable them in those deployments. This member will allow us to specify whether they should be deployed on all nodes, no nodes, or just masters.
openshift-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@cybertron: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
i think we would need an enhancement to add new fields to the |
|
Okay, enhancement proposed here: openshift/enhancements#127 |
| // See the documentation of the corresponding install-config member at | ||
| // https://github.com/openshift/installer/blob/master/pkg/types/baremetal/platform.go | ||
| // for details on which values are recognized. | ||
| UseMDNS string `json:"useMDNS,omitempty"` |
There was a problem hiding this comment.
This does not feel like the right place for this. I think this is instead of a configuration option on the dns config of a cluster. There is nothing specific to bare metal about this option.
There was a problem hiding this comment.
@cybertron would it better to add "UseMDNS" to other metal3 config items? See #540 for more details. It is still very much WIP.
There was a problem hiding this comment.
Possibly. It just needs to be consumable in the machine-config-operator templates.
I will note that this is baremetal-specific. It's used in the same MCO templates as the other entries in this structure, and it won't be used anywhere else. Most platforms don't use mdns services in the first place, and the ones that do have their own platform-specific configuration for it.
There was a problem hiding this comment.
The machine-api-operator would also have to look at this configuration before deploying metal3.
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
We've had new use cases presented where our mDNS services cannot be
used and are not needed, so we need a way to disable them in those
deployments. This member will allow us to specify whether they should
be deployed on all nodes, no nodes, or just masters.