Skip to content

Add UseMDNS member to baremetal platform status #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cybertron wants to merge 1 commit into from
Closed

Add UseMDNS member to baremetal platform status #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions config/v1/types_infrastructure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@ type BareMetalPlatformStatus struct {
// datacenter DNS, a DNS service is hosted as a static pod to serve those hostnames
// to the nodes in the cluster.
NodeDNSIP string `json:"nodeDNSIP,omitempty"`

// UseMDNS indicates where baremetal mDNS services should be deployed.
// See the documentation of the corresponding install-config member at
// https://github.com/openshift/installer/blob/master/pkg/types/baremetal/platform.go
// for details on which values are recognized.
UseMDNS string `json:"useMDNS,omitempty"`
Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton Nov 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not feel like the right place for this. I think this is instead of a configuration option on the dns config of a cluster. There is nothing specific to bare metal about this option.

Copy link
Copy Markdown
Contributor

@sadasu sadasu Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cybertron would it better to add "UseMDNS" to other metal3 config items? See #540 for more details. It is still very much WIP.

Copy link
Copy Markdown
Member Author

@cybertron cybertron Dec 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. It just needs to be consumable in the machine-config-operator templates.

I will note that this is baremetal-specific. It's used in the same MCO templates as the other entries in this structure, and it won't be used anywhere else. Most platforms don't use mdns services in the first place, and the ones that do have their own platform-specific configuration for it.

Copy link
Copy Markdown
Contributor

@sadasu sadasu Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The machine-api-operator would also have to look at this configuration before deploying metal3.

}

// OpenStackPlatformStatus holds the current status of the OpenStack infrastructure provider.
Expand Down