AGENT-1313: Add IRI manifest for OVE by pawanpinjarkar · Pull Request #612 · openshift/appliance

pawanpinjarkar · 2025-11-18T22:04:16Z

Adds InternalReleaseImage resource manifest for OVE

openshift-ci-robot · 2025-11-18T22:04:20Z

@pawanpinjarkar: This pull request references AGENT-1364 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Adds InternalReleaseImage resource manifest for OVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-11-18T22:05:08Z

/cc @andfasano @danielerez

andfasano · 2025-11-19T08:47:32Z

+			if len(parts) >= 2 {
+				version = parts[len(parts)-1]
+			}
+		}


This sounds like a piece of code that could deserve its own function, ie something like getCurrentOpenShiftVersion() ?

andfasano · 2025-12-01T14:34:06Z

/hold

Before landing this PR we'll need to test the integration of openshift/machine-config-operator#5452 with @danielerez work (ie #613)

openshift-ci-robot · 2025-12-15T14:09:15Z

@pawanpinjarkar: This pull request references AGENT-1313 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Adds InternalReleaseImage resource manifest for OVE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

andfasano · 2026-01-08T13:44:26Z

Requires also:

AGENT-1411: Preload the registry image when starting the iri-service machine-config-operator#5514
AGENT-1407: add support for InternalReleaseImage related resources assisted-service#8600

andfasano · 2026-01-15T11:08:03Z

/hold cancel

andfasano · 2026-01-15T15:05:59Z

+    - name: ocp-release-bundle-%s
+  `, version)
+
+        iriFile := ignition.FileFromString("/etc/assisted/extra-manifests/internalreleaseimage.yaml", "root", 0644, iriContent)


Until the installer min storage will be more robust, it will be useful to have a comment dropped here to remind to keep in sync the resource full path with openshift/installer#10176

andfasano · 2026-01-19T16:13:18Z

/lgtm

andfasano · 2026-01-19T16:13:34Z

cc @danielerez for approval

danielerez · 2026-01-20T09:14:45Z

/retest

danielerez

Looks good, just a missing blank line at EOF of the utils files.
Also the e2e tests fail, though seems unrelated. I'll check them.

andfasano · 2026-01-20T14:35:34Z

/lgtm

openshift-ci · 2026-01-20T14:40:21Z

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-sno-dualstack-dhcp	`f8bf726`	link	false	`/test e2e-sno-dualstack-dhcp`
ci/prow/e2e-compact-ipv4-static	`f8bf726`	link	true	`/test e2e-compact-ipv4-static`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

danielerez · 2026-01-20T15:07:32Z

/approve
/lgtm

openshift-ci · 2026-01-20T15:07:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [danielerez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 18, 2025

openshift-ci Bot requested review from andfasano, avishayt, danielerez and oourfali November 18, 2025 22:05

pawanpinjarkar force-pushed the add-irr-file-ove branch from a59b52a to 466c2a2 Compare November 18, 2025 23:28

andfasano reviewed Nov 19, 2025

View reviewed changes

pawanpinjarkar force-pushed the add-irr-file-ove branch from 466c2a2 to ef85f7b Compare November 19, 2025 16:40

pawanpinjarkar requested a review from andfasano November 19, 2025 16:41

andfasano reviewed Nov 20, 2025

View reviewed changes

Comment thread pkg/asset/ignition/recovery_ignition.go Outdated

andfasano reviewed Nov 20, 2025

View reviewed changes

Comment thread pkg/asset/ignition/recovery_ignition.go Outdated

pawanpinjarkar changed the title ~~AGENT-1364: Add IRR manifest for OVE~~ AGENT-1364: Add IRI manifest for OVE Nov 20, 2025

pawanpinjarkar requested a review from andfasano November 25, 2025 21:44

pawanpinjarkar force-pushed the add-irr-file-ove branch from 1016d24 to bab183c Compare November 25, 2025 22:22

andfasano reviewed Nov 26, 2025

View reviewed changes

Comment thread pkg/asset/ignition/recovery_ignition.go Outdated

pawanpinjarkar force-pushed the add-irr-file-ove branch from bab183c to 6d8ad39 Compare November 26, 2025 19:50

pawanpinjarkar requested a review from andfasano November 26, 2025 19:50

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2025

andfasano mentioned this pull request Dec 5, 2025

AGENT-1389: create InternalReleaseImage registry TLS certificate openshift/installer#10147

Merged

pawanpinjarkar changed the title ~~AGENT-1364: Add IRI manifest for OVE~~ AGENT-1313: Add IRI manifest for OVE Dec 15, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2026

andfasano mentioned this pull request Jan 15, 2026

AGENT-1313: enable MCO IRI registry openshift/agent-installer-utils#232

Merged

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2026

andfasano reviewed Jan 15, 2026

View reviewed changes

pawanpinjarkar force-pushed the add-irr-file-ove branch from 6d8ad39 to 53d2a55 Compare January 19, 2026 15:47

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2026

openshift-ci Bot assigned andfasano Jan 19, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2026

danielerez reviewed Jan 20, 2026

View reviewed changes

Comment thread pkg/utils/utils.go Outdated

Comment thread pkg/utils/utils_test.go Outdated

AGENT-1364: Add IRI extra manifest for OVE

f8bf726

pawanpinjarkar force-pushed the add-irr-file-ove branch from 53d2a55 to f8bf726 Compare January 20, 2026 14:12

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2026

openshift-ci Bot assigned danielerez Jan 20, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026

danielerez merged commit dea3c36 into openshift:master Jan 20, 2026
3 of 8 checks passed

pawanpinjarkar mentioned this pull request Jan 23, 2026

AGENT-1431: Backport feature NoRegistryClusterInstall to 4.21 #642

Merged

andfasano mentioned this pull request Mar 12, 2026

OCPBUGS-78250: add no-config-image and internalreleaseimage to disconnected ignition openshift/assisted-service#10001

Closed

Conversation

pawanpinjarkar commented Nov 18, 2025

Uh oh!

openshift-ci-robot commented Nov 18, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pawanpinjarkar commented Nov 18, 2025

Uh oh!

andfasano Nov 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andfasano commented Dec 1, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andfasano commented Jan 8, 2026

Uh oh!

andfasano commented Jan 15, 2026

Uh oh!

andfasano Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

pawanpinjarkar Jan 19, 2026

Choose a reason for hiding this comment

Uh oh!

andfasano commented Jan 19, 2026

Uh oh!

andfasano commented Jan 19, 2026

Uh oh!

danielerez commented Jan 20, 2026

Uh oh!

danielerez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

andfasano commented Jan 20, 2026

Uh oh!

openshift-ci Bot commented Jan 20, 2026

Uh oh!

danielerez commented Jan 20, 2026

Uh oh!

openshift-ci Bot commented Jan 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci-robot commented Nov 18, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Dec 15, 2025 •

edited by openshift-ci Bot

Loading