promotion: handle "master*" branch same as master#237
Closed
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
Closed
promotion: handle "master*" branch same as master#237vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/XS
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
vrutkovs
force-pushed
the
fcos-master-promotion
branch
from
7ae5af5 to
f307b91
Compare
openshift-ci-robot
added
size/S
vrutkovs
force-pushed
the
fcos-master-promotion
branch
from
f307b91 to
6d5c185
Compare
vrutkovs
changed the title
vrutkovs
force-pushed
the
fcos-master-promotion
branch
2 times, most recently
from
bb1889e to
3a8d6cb
Compare
OKD-on-FCOS testing requires some projects to have master temporarily forked in "master-fcos" branches. This uses correct promotion flavor for these kind of branchs
vrutkovs
force-pushed
the
fcos-master-promotion
branch
from
3a8d6cb to
5a61144
Compare
Contributor
Author
|
/hold It seems |
openshift-ci-robot
added
the
do-not-merge/hold
| func FlavorForBranch(branch string) string { | ||
| var flavor string | ||
| if branch == "master" { | ||
| if masterBranches.MatchString(branch) { |
Contributor
There was a problem hiding this comment.
The glob he have today is here:
ci-operator/config/**/*master*.yaml:
name: ci-operator-master-configs
additional_namespaces:
- ci-stgThat would match not-really-master-branch
Contributor
Author
|
This is no longer required - we settled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OKD-on-FCOS testing requires some projects to have master temporarily
forked in "master-fcos" branches. This uses correct promotion flavor for
those.
Fixes sharded config tests in openshift/release#5557 and openshift/release#5589