Add a job to promote MCD from fcos-master branch #5557
Add a job to promote MCD from fcos-master branch #5557vrutkovs wants to merge 2 commits intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6af4ccd to
6477275
Compare
6477275 to
8d8e10a
Compare
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
If we're going to have a dedicated branch that is not using CI, it needs to
be called "fcos" for now (master in the branch name will just confuse
various things).
…On Thu, Oct 24, 2019 at 4:19 PM Vadim Rutkovsky ***@***.***> wrote:
/cc @LorbusChris <https://github.com/LorbusChris> @smarterclayton
<https://github.com/smarterclayton>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5557?email_source=notifications&email_token=AAI37J5NLIXBQOHVB7TOCCLQQH7O3A5CNFSM4JEBKOZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECGJYHI#issuecomment-546085917>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI37J47SOHUZJXJSEPXY5DQQH7O3ANCNFSM4JEBKOZQ>
.
|
| @@ -0,0 +1,41 @@ | |||
| base_images: | |||
There was a problem hiding this comment.
you need to define the explicit base images here you want from fcos, i.e.:
base_images:
...
machine-os-content:
namespace: fcos
name: 4.3
tag: machine-os-content
// any other images that differ, like installer
| to: machine-config-operator | ||
| promotion: | ||
| name: "4.3" | ||
| namespace: fcos |
There was a problem hiding this comment.
this is probably fine as a promotion target. I think we'll want a separate job that takes over from the okd promotion flow that combines the three custom images here (machine-os-content, machine-config-operator, and installer) tests them with the latest okd images, and promotes them.
Once we have these publishing to fcos I will update the release controller so that it stops publishing the three images from ocp to okd, and instead we'll side load them via the job I mentioned.
Not entirely sure about
tag_specification/cc @smarterclayton