Skip to content

Add a job to promote MCD from fcos-master branch #5557

Closed
vrutkovs wants to merge 2 commits intoopenshift:masterfrom
vrutkovs:mcd-fcos-master
Closed

Add a job to promote MCD from fcos-master branch #5557
vrutkovs wants to merge 2 commits intoopenshift:masterfrom
vrutkovs:mcd-fcos-master

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

Not entirely sure about tag_specification

/cc @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 23, 2019
@vrutkovs vrutkovs changed the title Add a job to promote MCD from fcos-master branch WIP Add a job to promote MCD from fcos-master branch Oct 23, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign ashcrow
You can assign the PR to them by writing /assign @ashcrow in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2019
@vrutkovs vrutkovs changed the title WIP Add a job to promote MCD from fcos-master branch Add a job to promote MCD from fcos-master branch Oct 24, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/fcos-master/e2e-gcp-upgrade 64772758ace9efc0c16ded286743100617dcaf86 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos-master/e2e-gcp-op 64772758ace9efc0c16ded286743100617dcaf86 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos-master/e2e-aws-scaleup-rhel7 64772758ace9efc0c16ded286743100617dcaf86 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos-master/e2e-aws-disruptive 64772758ace9efc0c16ded286743100617dcaf86 link /test pj-rehearse
ci/prow/correctly-sharded-config efb1d29 link /test correctly-sharded-config
ci/prow/generated-config efb1d29 link /test generated-config
ci/rehearse/openshift/machine-config-operator/fcos-master/images efb1d29 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos-master/verify efb1d29 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos-master/unit efb1d29 link /test pj-rehearse
ci/rehearse/openshift/machine-config-operator/fcos-master/e2e-aws efb1d29 link /test pj-rehearse
ci/prow/pj-rehearse efb1d29 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

/cc @LorbusChris @smarterclayton

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 25, 2019 via email

@@ -0,0 +1,41 @@
base_images:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to define the explicit base images here you want from fcos, i.e.:

base_images:
  ...
  machine-os-content:
     namespace: fcos
     name: 4.3
     tag: machine-os-content
  // any other images that differ, like installer

to: machine-config-operator
promotion:
name: "4.3"
namespace: fcos
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably fine as a promotion target. I think we'll want a separate job that takes over from the okd promotion flow that combines the three custom images here (machine-os-content, machine-config-operator, and installer) tests them with the latest okd images, and promotes them.

Once we have these publishing to fcos I will update the release controller so that it stops publishing the three images from ocp to okd, and instead we'll side load them via the job I mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants