secret-wrapper: unify input and output directories #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the input directory (where the secret is mounted) to the output directory and use that to overwrite the secret after the wrapped command is executed. This is done so the program: - deals with a single directory - does not have to copy files manually to preserve them - can delete files from the secret by removing them from the directory
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
petr-muller
approved these changes
Mar 11, 2020
Member
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
/hold
LGTM, holding to allow someone more involved to review if needed.
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
bbguimaraes
added a commit
to bbguimaraes/ci-tools
that referenced
this pull request
Mar 12, 2020
Document the new mode of operation introduced in openshift#544.
This was referenced Mar 12, 2020
openshift-merge-robot
pushed a commit
to openshift/release
that referenced
this pull request
Mar 13, 2020
After openshift/ci-tools#544, `$SHARED_DIR` should be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the input directory (where the secret is mounted) to the output
directory and use that to overwrite the secret after the wrapped command
is executed. This is done so the program: