ci-operator/step-registry/ipi: Drop /tmp/secret mkdirs

[wking]

Fixing errors like:

2020/03/12 23:45:35 Container cp-secret-wrapper in pod e2e-steps-ipi-conf completed successfully
mkdir: cannot create directory '/tmp/secret': File exists
error: [failed to execute wrapped command: exit status 1]
2020/03/12 23:45:37 Container ipi-conf in pod e2e-steps-ipi-conf failed, exit code 1, reason Error

I haven't traced this back to see when it broke, but I'd guess some ci-tools code is now creating /tmp/secret for each container.

[wking]

e2e-steps died on CI registry flakes and similar:

error: build error: Failed to push image: received unexpected HTTP status: 500 Internal Server Error
  * step ovirt-installer failed: could not wait for build: the build ovirt-installer failed after 5m14s with reason PushImageToRegistryFailed: Failed to push the image to the registry.

/retest

[wking]

Hmm, doesn't seem to have stuck. Trying more directly:

/test pj-rehearse

[wking]

Hrm:

level=error msg="Error: [ERR]: Error building changeset: InvalidChangeBatch: [Tried to create resource record set [name='api.ci-op-vvtn0znp-a9648.origin-ci-int-aws.dev.rhcloud.com.', type='A'] but it already exists]"
level=error msg="\tstatus code: 400, request id: f0d30ddf-bbb2-4839-b8cc-875876f4f964"

Cleaning up my project so I get a fresh namespace:

$ oc delete project ci-op-vvtn0znp

And trying again:

/test pj-rehearse

[bbguimaraes]

This was caused by openshift/ci-tools#544.

I ended up running out of time yesterday, thanks for fixing it.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/ipi/conf/OWNERS [bbguimaraes,wking]
• ci-operator/step-registry/ipi/install/install/OWNERS [bbguimaraes,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@wking: Updated the step-registry configmap in namespace ci at cluster default using the following files:

• key ipi-conf-commands.sh using file ci-operator/step-registry/ipi/conf/ipi-conf-commands.sh
• key ipi-install-install-commands.sh using file ci-operator/step-registry/ipi/install/install/ipi-install-install-commands.sh

Details

In response to this:

Fixing errors like:

2020/03/12 23:45:35 Container cp-secret-wrapper in pod e2e-steps-ipi-conf completed successfully
mkdir: cannot create directory '/tmp/secret': File exists
error: [failed to execute wrapped command: exit status 1]
2020/03/12 23:45:37 Container ipi-conf in pod e2e-steps-ipi-conf failed, exit code 1, reason Error

I haven't traced this back to see when it broke, but I'd guess some ci-tools code is now creating /tmp/secret for each container.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.