build_deploy.sh: don't create temporary release dir#222
Conversation
Its being handled by multistage build now. This fixes stage build errors
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
| rmdir ${RELEASE_OUTPUT_DIR} | ||
| fi | ||
| } | ||
| trap cleanup EXIT |
There was a problem hiding this comment.
Could you just remove this line and leave the cleanup function in place? It would be nice if we could just disable the trap on CI builds, because it's still useful for people running the testsuite locally in the container environment.
There was a problem hiding this comment.
it won't work, there is nothing to clean up because we don't create intermediate dir with binaries and dockerfile. This happens in builder stage of Dockerfile.deploy
There was a problem hiding this comment.
Because we are using a multi-stage build.
There was a problem hiding this comment.
I'm not convinced but I'd like to get the builds working again, so I'll take a look at the end-result 🤷♂️
|
/retest |
| rmdir ${RELEASE_OUTPUT_DIR} | ||
| fi | ||
| } | ||
| trap cleanup EXIT |
There was a problem hiding this comment.
I'm not convinced but I'd like to get the builds working again, so I'll take a look at the end-result 🤷♂️
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, steveeJ, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Its being handled by multistage build now. This fixes stage build errors