build_deploy: fix docker build CLI syntax#223
Conversation
docker build needs `-f <dockerfile path> <directory>` args
| DOCKERFILE_DEPLOY="$ABSOLUTE_PATH/Dockerfile.deploy/Dockerfile" | ||
|
|
||
| docker build -t "${IMAGE}:${IMAGE_TAG}" $DOCKERFILE_DEPLOY | ||
| docker build -t "${IMAGE}:${IMAGE_TAG}" -f $DOCKERFILE_DEPLOY . |
There was a problem hiding this comment.
In #24 the script was reworked to create a temp dir and copying binaries produced by cargo build --release there. In multistage build its no longer required, so the context is set to the whole dir and it requires the path to dockerfile
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vrutkovs: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
docker build needs
-f <dockerfile path> <directory>argsFixes stage build: