Skip to content

dist/openshift/cincinnati-e2e: Set targetNamespaces#728

Closed
wking wants to merge 2 commits into
openshift:masterfrom
wking:set-targetNamespaces-for-e2e
Closed

dist/openshift/cincinnati-e2e: Set targetNamespaces#728
wking wants to merge 2 commits into
openshift:masterfrom
wking:set-targetNamespaces-for-e2e

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Aug 12, 2022

In the OperatorGroup, as seen here and here, to catch up with the operator moving AllNamespaces support from true to false in installModes. This avoids:

+ oc get events
LAST SEEN   TYPE      REASON                     OBJECT                                                 MESSAGE
10m         Warning   UnsupportedOperatorGroup   clusterserviceversion/update-service-operator.v5.0.0   AllNamespaces InstallModeType not supported, cannot configure to watch all namespaces

@wking wking mentioned this pull request Aug 12, 2022
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2022
@wking wking force-pushed the set-targetNamespaces-for-e2e branch from 4f1f7e9 to 983d7ff Compare August 12, 2022 12:37
@wking
dist/openshift/cincinnati-e2e: Set targetNamespaces
42136c5 
In the OperatorGroup, as seen in [1,2], to catch up with the operator
moving AllNamespaces support from true to false in installModes [3].
This avoids [4]:

  + oc get events
  LAST SEEN   TYPE      REASON                     OBJECT                                                 MESSAGE
  10m         Warning   UnsupportedOperatorGroup   clusterserviceversion/update-service-operator.v5.0.0   AllNamespaces InstallModeType not supported, cannot configure to watch all namespaces

[1]: https://github.com/openshift/cincinnati-operator/blob/eed7a92a5efda96545e9be90a6ec65b427026d11/docs/disconnected-updateservice-operator.md#deploy-the-updateservice-operator
[2]: https://github.com/openshift/cincinnati-operator/blob/eed7a92a5efda96545e9be90a6ec65b427026d11/tools/create-sub-group.sh#L23-L25
[3]: openshift/cincinnati-operator@1137a5c#diff-ef93a20b4f66d5fb3e6d84caf1169c43d4f750684fabd1a7c27065312dbb7fcdL73-R73
[4]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/31237/rehearse-31237-pull-ci-openshift-cincinnati-master-e2e/1557865068975099904#1:build-log.txt%3A897-899
@wking wking force-pushed the set-targetNamespaces-for-e2e branch from 983d7ff to 42136c5 Compare August 13, 2022 05:55
@PratikMahajan
Copy link
Copy Markdown
Contributor

PratikMahajan commented Aug 15, 2022

/retest

@wking
hack/e2e: Update e2e-policy-engine-route to e2e-route
00e27c9 
Catching up with openshift/cincinnati-operator@8cea4f3383 (OTA-423:
Validate route host before creating app, 2021-10-18,
openshift/cincinnati-operator#135), which dropped the '-policy-engine'
scoping.
@wking
Copy link
Copy Markdown
Member Author

wking commented Aug 15, 2022

I've pushed 42136c5 -> 00e27c9 to avoid:

++ oc get route e2e-policy-engine-route -o 'jsonpath={.spec.host}'
Error from server (NotFound): routes.route.openshift.io "e2e-policy-engine-route" not found

by catching up with openshift/cincinnati-operator#135.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 15, 2022

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/customrust-e2e 00e27c9 link true /test customrust-e2e
ci/prow/e2e 00e27c9 link true /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Copy Markdown
Member Author

wking commented Aug 19, 2022

Closing in favor of #719.

@wking wking closed this Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LalatenduMohanty LalatenduMohanty Awaiting requested review from LalatenduMohanty

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wking @PratikMahajan