ci-operator/config/openshift: Decouple Cincinnati ecosystem from OpenShift branching#31237
Merged
openshift-merge-robot merged 1 commit intoAug 22, 2022
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
openshift-ci
Bot
added
the
approved
wking
force-pushed
the
decouple-cincinnati-ecosystem-from-openshift-branching
branch
2 times, most recently
from
be50523 to
7c95530
Compare
openshift-ci
Bot
removed
the
approved
wking
force-pushed
the
decouple-cincinnati-ecosystem-from-openshift-branching
branch
2 times, most recently
from
79ca6aa to
cec0f70
Compare
Contributor
|
looks like we need to fix cincinnati tests before merging this PR |
Member
Author
|
Hmm, yeah, both have |
Member
Author
|
I've filed openshift/cincinnati#727, adding the group information to the Template |
Member
Author
|
openshift/cincinnati#727 merged. /test pj-rehearse |
Member
Author
|
Looks like the next tweak we need is dropping all namespaces, to avoid: |
Member
Author
|
openshift/cincinnati#728 will hopefully address the |
Member
Author
|
openshift/cincinnati#719 merged. /retest |
Member
Author
|
Two rehearsals had: /hold |
openshift-ci
Bot
added
the
do-not-merge/hold
…Shift branching
graph-data only has a development branch. Cincinnati and its operator
recently pivoted to a similar model, releasing an OpenShift Update
Service 5.0 on 2022-08-03 [1] based on the master branches. This
commit rips out all the old release-* stuff, and also:
* Drops 'releases' in favor of cluster claims [2], because we are
decoupled from the OpenShift core and do not need to install a fresh
cluster for our testing.
* Drops 'promotion'. We'd already had most of our images in
exclude_images, so not much change in terms of actually-promoted
images. But dropping the promotion property opts us out of
OpenShift branching [3].
* Pivots cincinnati-operator from 'stable' to 'pipeline' sources, as
suggested by [4]:
pipeline ...output images as defined in images...
...
stable Same as [stable-<name>], but for the release:latest release payload. Appropriate tags are overridden using the container images built during the test.
not entirely clear to me why "Appropriate tags are overridden using
the container images" doesn't cover me here. Possibly because I
dropped the 'promotion' block. But without this change I get
failures like [5]:
could not determine image pull spec for image stable:cincinnati-operator on step e2e-test
[1]: https://access.redhat.com/errata/RHEA-2022:5871
[2]: https://docs.ci.openshift.org/docs/architecture/ci-operator/#testing-with-a-cluster-from-a-cluster-pool
[3]: https://docs.ci.openshift.org/docs/architecture/branching/#how-do-i-opt-my-repository-into-automated-branching
[4]: https://docs.ci.openshift.org/docs/architecture/ci-operator/#referencing-images
[5]: openshift#31237 (comment)
wking
force-pushed
the
decouple-cincinnati-ecosystem-from-openshift-branching
branch
from
cec0f70 to
2a23427
Compare
Contributor
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
Author
|
graph-data e2e hit a Quay 500. /retest |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, PratikMahajan, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Member
Author
|
Oops, CI is green, so this is stale. /hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
|
@wking: Updated the following 24 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
deleted the
decouple-cincinnati-ecosystem-from-openshift-branching
branch
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Dec 2, 2022
…a image We'd removed similar publishing in 45509b1 (ci-operator/config/openshift: Decouple Cincinnati ecosystem from OpenShift branching, 2022-08-22, openshift#31237). But it turns out some folks are interested in a graph-data image that contains only YAML configuration, even if those images are not produced by Red Hat's internal build system and signed. This commit asks Prow to build and promote a from-scratch graph-data image for those consumers, using the dockerfile_literal approach from [1] and the 'paths' approach from [1,2]. [1]: https://docs.ci.openshift.org/docs/architecture/ci-operator/#building-container-images [2]: https://docs.openshift.com/container-platform/4.11/cicd/builds/creating-build-inputs.html#builds-image-source_creating-build-inputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graph-data only has a development branch. Cincinnati and its operator recently pivoted to a similar model, releasing an OpenShift Update Service 5.0 on 2022-08-03 based on the master branches. This commit rips out all the old release-* stuff, and also:
Drops
releasesin favor of cluster claims 1, because we are decoupled from the OpenShift core and do not need to install a fresh cluster for our testing.Drops
promotion. We'd already had most of our images inexclude_images, so not much change in terms of actually-promoted images. But dropping the promotion property opts us out of OpenShift branching.