ci-operator/config/openshift/cincinnati-graph-data: Publish graph-data image#34475
ci-operator/config/openshift/cincinnati-graph-data: Publish graph-data image#34475wking wants to merge 1 commit into
Conversation
|
@wking: the following rehearsable tests have been affected by this change:
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
87fa995 to
713e81b
Compare
|
/pj-rehearse |
f6f99b3 to
5a04da3
Compare
|
/pj-rehearse |
…a image We'd removed similar publishing in 45509b1 (ci-operator/config/openshift: Decouple Cincinnati ecosystem from OpenShift branching, 2022-08-22, openshift#31237). But it turns out some folks are interested in a graph-data image that contains only YAML configuration, even if those images are not produced by Red Hat's internal build system and signed. This commit asks Prow to build and promote a from-scratch graph-data image for those consumers, using the dockerfile_literal approach from [1] and the 'paths' approach from [1,2]. [1]: https://docs.ci.openshift.org/docs/architecture/ci-operator/#building-container-images [2]: https://docs.openshift.com/container-platform/4.11/cicd/builds/creating-build-inputs.html#builds-image-source_creating-build-inputs
5a04da3 to
534e0ff
Compare
|
/pj-rehearse |
|
/pj-rehearse ack With a build03 registry token, using the output of the rehearsal job: $ oc image mirror registry.build03.ci.openshift.org/ci-op-n1pkzi1j/stable:graph-data file://graph-data/:latest
$ tree v2
v2
└── graph-data
├── blobs
│ ├── sha256:652d957b74550724ff8a7a00ae3a36a1a69d8ab9da1fff3c7fcb3e0df33939a4
│ ├── sha256:9318a8e36ef583f50017c8e57fcdc7113ca46e60ff6eabbff961cb81ca07a775
│ └── sha256:a431d5bdd3fd8a54de2cc2762416728cc0b71afb275cd4c04cc31b258dcbfb1c
└── manifests
├── latest -> sha256:652d957b74550724ff8a7a00ae3a36a1a69d8ab9da1fff3c7fcb3e0df33939a4
└── sha256:652d957b74550724ff8a7a00ae3a36a1a69d8ab9da1fff3c7fcb3e0df33939a4
$ jq . v2/graph-data/manifests/latest
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"config": {
"mediaType": "application/vnd.docker.container.image.v1+json",
"size": 3986,
"digest": "sha256:a431d5bdd3fd8a54de2cc2762416728cc0b71afb275cd4c04cc31b258dcbfb1c"
},
"layers": [
{
"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
"size": 17021,
"digest": "sha256:9318a8e36ef583f50017c8e57fcdc7113ca46e60ff6eabbff961cb81ca07a775"
}
]
}
$ sha256sum v2/graph-data/manifests/latest
652d957b74550724ff8a7a00ae3a36a1a69d8ab9da1fff3c7fcb3e0df33939a4 v2/graph-data/manifests/latest
$ tar tvz <v2/graph-data/blobs/sha256:9318a8e36ef583f50017c8e57fcdc7113ca46e60ff6eabbff961cb81ca07a775 | head -n4
drwxr-xr-x root/root 0 2022-12-02 05:04 blocked-edges/
-rw-r--r-- root/root 19 2022-12-02 05:04 blocked-edges/4.1.1.yaml
-rw-r--r-- root/root 20 2022-12-02 05:04 blocked-edges/4.1.10.yaml
-rw-r--r-- root/root 145 2022-12-02 05:04 blocked-edges/4.10.0-fc.0.yaml
$ tar tvz <v2/graph-data/blobs/sha256:9318a8e36ef583f50017c8e57fcdc7113ca46e60ff6eabbff961cb81ca07a775 | grep -v '[.]yaml$'
drwxr-xr-x root/root 0 2022-12-02 05:04 blocked-edges/
drwxr-xr-x root/root 0 2022-12-02 05:04 channels/
drwxr-xr-x root/root 0 2022-12-02 05:04 raw/
-rw-r--r-- root/root 380 2022-12-02 05:04 raw/metadata.jsonSo that's a single layer with just the YAML/JSON config that Cincinnati needs, an image config, and an image manifest to tie the config and layer together, which is exactly what I wanted. |
petr-muller
left a comment
There was a problem hiding this comment.
/hold
Configuration LGTM. There are still some discussions whether we actually want this or not, so holding, but feel free to unhold.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
We're still discussing whether this is useful for QE or anything. /hold |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We'd removed similar publishing in 45509b1 (#31237). But it turns out some folks are interested in a graph-data image that contains only YAML configuration, even if those images are not produced by Red Hat's internal build system and signed. This commit asks Prow to build and promote a from-scratch graph-data image for those consumers, using the
dockerfile_literalapproach.