Skip to content

Remove cincinnati-operator configs from o-priv#32230

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jmguzik:c-operator
Sep 13, 2022
Merged

Remove cincinnati-operator configs from o-priv#32230
openshift-merge-robot merged 1 commit into
openshift:masterfrom
jmguzik:c-operator

Conversation

@jmguzik
Copy link
Copy Markdown
Contributor

@jmguzik jmguzik commented Sep 13, 2022

Since merging: #31237 our automation: #31573 fails on trying to partly delete cincinnati-operator from prow config.

My proposition is to delete fully this configuration from openshift-priv (which is the reason of failure) as files that caused cincinnati-operator configs to be reconciled were removed in #31237

/cc @hongkailiu @wking
@wking I am cc-ing also you as you are the author of discussed PR

Signed-off-by: Jakub Guzik jguzik@redhat.com

Signed-off-by: Jakub Guzik <jguzik@redhat.com>
@openshift-ci openshift-ci Bot requested review from hongkailiu and wking September 13, 2022 08:42
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2022
@danilo-gemoli
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@jmguzik
Copy link
Copy Markdown
Contributor Author

jmguzik commented Sep 13, 2022

@hongkailiu @wking I have asked Danilo to LGTM this to enable our automation. If there are serious concerns against doing that we will revert.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, jmguzik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@jmguzik: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 012e64f into openshift:master Sep 13, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 13, 2022

@jmguzik: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-priv-cincinnati-operator-_pluginconfig.yaml using file ``
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-priv-cincinnati-operator-_prowconfig.yaml using file ``
Details

In response to this:

Since merging: #31237 our automation: #31573 fails on trying to partly delete cincinnati-operator from prow config.

My proposition is to delete fully this configuration from openshift-priv (which is the reason of failure) as files that caused cincinnati-operator configs to be reconciled were removed in #31237

/cc @hongkailiu @wking
@wking I am cc-ing also you as you are the author of discussed PR

Signed-off-by: Jakub Guzik jguzik@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants