Bug 1883691: Add validation for logLevel by dmage · Pull Request #252 · openshift/cloud-credential-operator

dmage · 2020-09-29T10:24:36Z

openshift/api#736 added restrictions for logLevel values. This PR vendors new openshift/api to get new CRDs.

openshift-ci-robot · 2020-09-29T10:24:43Z

@dmage: This pull request references Bugzilla bug 1878040, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1878040: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dmage · 2020-09-29T10:27:16Z

/assign @dgoodwin @joelddiaz

openshift-ci-robot · 2020-09-29T10:29:19Z

@dmage: This pull request references Bugzilla bug 1878040, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1878040: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2020-09-29T12:04:55Z

/hold

sttts · 2020-09-29T15:09:24Z

/lgtm
/hold cancel

openshift-ci-robot · 2020-09-29T15:09:41Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmage, sttts
To complete the pull request process, please assign dgoodwin
You can assign the PR to them by writing /assign @dgoodwin in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dmage · 2020-09-29T21:21:56Z

/retitle Bug 1883691: Add validation for logLevel

openshift-ci-robot · 2020-09-29T21:22:18Z

@dmage: An error was encountered adding this pull request to the external tracker bugs for bug 1883691 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/cloud-credential-operator/pulls/252 Error: 403 Forbidden at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894c...', 'https://api.github.com/repos/openshift/cloud-credential-opera...', 'GET') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x55894c...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894cf4c308)') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x55894cf4c308)', 1) called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55894cf30968)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x55894c0c15d8)', 'HASH(0x55894c2556e8)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x55894c2556e8)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x55894c5e2850)') called at /loader/0x5589446ba9a8/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894c79d7d8)') called at (eval 2154) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894ce05f40)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x55894ce05f40)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55894c3c8580)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55894c2b0328)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55894c2b0328)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894c3c8580)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55894c3c8580)') called at (eval 2154) line 0 eval {...} called at (eval 2154) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1883691: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dmage · 2020-09-29T21:22:28Z

/bugzilla refresh

openshift-ci-robot · 2020-09-29T21:22:31Z

@dmage: This pull request references Bugzilla bug 1883691, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sttts · 2020-09-30T07:47:48Z

/retest

dgoodwin · 2020-12-04T12:57:47Z

Sorry, needs a merge conflict update. :(

dgoodwin · 2020-12-17T17:12:38Z

@dmage can you resolve these conflicts so this will merge.

dmage · 2021-01-05T13:40:29Z

@dgoodwin openshift/api was bumped by #260. Nothing else is needed.

openshift-ci-robot · 2021-01-05T13:40:36Z

@dmage: This pull request references Bugzilla bug 1883691. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

Bug 1883691: Add validation for logLevel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 29, 2020

openshift-ci-robot requested review from csrwng and joelddiaz September 29, 2020 10:24

openshift-ci-robot assigned dgoodwin and joelddiaz Sep 29, 2020

dmage force-pushed the loglevel-validation branch 2 times, most recently from 2e79004 to 78268bf Compare September 29, 2020 10:47

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020

dmage force-pushed the loglevel-validation branch from 78268bf to 9122dfe Compare September 29, 2020 13:40

bump(github.com/openshift/api): add logLevel validation

70a21b4

dmage force-pushed the loglevel-validation branch from 9122dfe to 70a21b4 Compare September 29, 2020 14:37

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020

openshift-ci-robot assigned sttts Sep 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020

openshift-ci-robot changed the title ~~Bug 1878040: Add validation for logLevel~~ Bug 1883691: Add validation for logLevel Sep 29, 2020

dmage closed this Jan 5, 2021

Conversation

dmage commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

sttts commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

dmage commented Sep 29, 2020

Uh oh!

openshift-ci-robot commented Sep 29, 2020

Uh oh!

sttts commented Sep 30, 2020

Uh oh!

dgoodwin commented Dec 4, 2020

Uh oh!

dgoodwin commented Dec 17, 2020

Uh oh!

dmage commented Jan 5, 2021

Uh oh!

openshift-ci-robot commented Jan 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dmage commented Sep 29, 2020 •

edited

Loading