Bug 1878040: Validations for LogLevel fields

[ricardomaraschini]

As it is stated on OperatorSpec.LogLevel documentation valid values for the type LogLevel are Normal, Debug, Trace and TraceAll. Adding pattern validation for the LogLevel type seems to make sense.

This affected multiple CRDs, not sure if we can simply enforce this here or what would be the right approach to make sure all other operators comply with them. Other than that I am not sure these validations were omitted on purpose due some unknown reason.

[openshift-ci-robot]

@ricardomaraschini: This pull request references Bugzilla bug 1878040, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

WIP - Bug 1878040: Validations for LogLevel fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@ricardomaraschini: This pull request references Bugzilla bug 1878040, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

WIP - Bug 1878040: Validations for LogLevel fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@ricardomaraschini: This pull request references Bugzilla bug 1878040, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

WIP - Bug 1878040: Validations for LogLevel fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ricardomaraschini]

/assign @dmage @sttts

[sttts]

/hold

We have to wait until we have a cluster-config-operator controller in place that cleans up existing log level, compare openshift/cluster-config-operator#150

[dmage]

@sttts the PR that you mention is for 4.5, for openshift/cluster-config-operator#151 is for master and it is merged. Can we unhold this PR?

[sttts]

openshift/cluster-config-operator#150 merged.

/lgtm
/approve

We now have to bump this into all these operators:

		{
			Group:    "imageregistry.operator.openshift.io",
			Version:  "v1",
			Resource: "configs",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "configs",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "etcds",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "kubeapiservers",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "kubecontrollermanagers",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "kubeschedulers",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "openshiftapiservers",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "cloudcredentials",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "kubestorageversionmigrators",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "authentications",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "openshiftcontrollermanagers",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "storages",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "networks",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "consoles",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "csisnapshotcontrollers",
		},
		{
			Group:    "operator.openshift.io",
			Version:  "v1",
			Resource: "clustercsidrivers",
		},

[sttts]

/hold cancel

[ricardomaraschini]

/retest

[sttts]

/retest

[dmage]

/retest

[sttts]

/retest

[droslean]

/test unit

[droslean]

/retest

[sttts]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ricardomaraschini, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@ricardomaraschini: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/cluster-storage-operator#92 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1878040 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1878040: Validations for LogLevel fields

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.